Add minimal as/dis support for TOSA.001000.1 extended instruction set

[kpet]

Change-Id: Ieefcd9c9a46dc3021c1600c02f9be96c49641aa9

[kpet]

Headers: KhronosGroup/SPIRV-Headers#526

[kpet]

So, it looks like SPIRV-Tools has its own logic to regenerate the SPIR-V headers when building with Bazel. I am not sure why but, assuming this will not change, it looks like I'm going to need Bazel definitions for the new instruction set added to the headers (KhronosGroup/SPIRV-Headers#527), a few changes to add the new instruction set to BUILD.bazel, and either changes to the utils/generate_language_headers.py script in this repo or its removal in favour of the more recent copy in SPIRV-Headers (see #6186).

What direction do maintainers prefer?

[dneto0]

So, it looks like SPIRV-Tools has its own logic to regenerate the SPIR-V headers when building with Bazel. I am not sure why but, assuming this will not change, it looks like I'm going to need Bazel definitions for the new instruction set added to the headers (KhronosGroup/SPIRV-Headers#527), a few changes to add the new instruction set to BUILD.bazel, and either changes to the utils/generate_language_headers.py script in this repo or its removal in favour of the more recent copy in SPIRV-Headers (see #6186).

What direction do maintainers prefer?

Sorry for the confusion:

The error is that the bazel build can't find the TOSA header from spirv-headers:

test/ext_inst.tosa_test.cpp:19:10: fatal error: spirv/unified1/TOSA.001000.1.h: No such file or directory
   19 | #include "spirv/unified1/TOSA.001000.1.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The fix is to add an entry for include/spirv/unified1/TOSA.001000.1.h to the list here

That's one flow. It does not (directly) use the generate_language_headers.py script in either repo. It uses the checked-in .h file.

The Android.mk, the BUILD.gn flow (chromium) use utils/generate_language_headers.py script in SPIRV-Tools.

• I see now that in the BUILD.gn case it looks redundant. Update the list here and I think it will work without needing to update the .py script.
• For Android.mk I think it ended up working in bots because it does not use a hermetic build, and so it picked up the checked-in TOSA header without needing to generate it locally.

I think this implies I can do a bunch of cleanups.

To get this PR to pass, we only need the update to BUILD.bazel in SPIRV-Headers. I'll make a PR for that.

[dneto0]

I posted KhronosGroup/SPIRV-Headers#529

With that, this PR builds on Bazel (tested on Linux).

[kpet]

Thanks for the help with this PR David, much appreciated! I've approved and merged your SPIRV-Headers PR and picked it up here. This enabled progress but I'm still hitting a few issues. Going through the CI failures:

• CI-ubuntu-gcc-release/CI-ubuntu-gcc-debug/CI-ubuntu-clang-ubsan: seems CMake wasn't able to find re2 or protobuf. CI hiccup?
• CI-macos-clang-release-bazel/CI-ubuntu-clang-release-bazel: both fail with the following error

test/ext_inst.tosa_test.cpp:19:10: error: module //:base_ext_inst.tosa_test does not depend on a module exporting 'spirv/unified1/TOSA.001000.1.h'
#include "spirv/unified1/TOSA.001000.1.h"

Looks like I'm missing a dependency in BUILD.bazel. I should be able to figure that one out.

• Github Actions Build and Test with Bazel: built correctly but the test I added is failing (and passing in other jobs):

 error: 2: 22: Invalid extended instruction name 'ARGMAX'.

It looks like the instruction set is not included in tables in Bazel builds.

[kpet]

So Bazel jobs are now passing but there are still a couple of failures that I don't think have anything to do with this PR:

• CI-macos-clang-release Clang crashing on a file that I did not change :(
• CI-ubuntu-gcc-debug CMake can't find abseil_cpp. Looks unrelated to this PR.

[dneto0]

• CI-ubuntu-gcc-debug: fatal: unable to access 'https://github.com/abseil/abseil-cpp.git/': Could not resolve host: github.com I should be able to trigger another attempt internally.
• CI-macos-clang-release: clang: error: unable to execute command: Segmentation fault: 11 . Again likely transient. I'll trigger again.

[dneto0]

The changes to BUILD.gn affect the GN build for Chromium. Unfortunately that build is not tested in this repo, but only when we (Chrome) tries to roll it into Chromium. I'll try to get this landed, then reapply the BUILD.gn changes soon after.

[kpet]

Thank you!