Simplify extinst generation #6095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dneto0
commented
Apr 16, 2025
dneto0
commented
Collaborator
Author
dneto0
force-pushed
the
simplify-extinst-generation
branch
2 times, most recently
from
e8e6fc2 to
b6c63d0
Compare
dneto0
force-pushed
the
simplify-extinst-generation
branch
2 times, most recently
from
76d655f to
d1b6117
Compare
Generate glsl.std.450 and opencl.std.100 extended instruction tables the same way other vendor extended instruction tables are generated. The naming is a little weird, but I wanted to keep this patch simple because it touches so many build systems. Also: - Don't always assume operand_kinds exists
dneto0
force-pushed
the
simplify-extinst-generation
branch
from
43341cc to
c1b8ba9
Compare
alan-baker
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.