Initial support for SPV_KHR_integer_dot_product#4327
Merged
alan-baker merged 2 commits intoKhronosGroup:masterfrom Jun 23, 2021
Merged
Initial support for SPV_KHR_integer_dot_product#4327alan-baker merged 2 commits intoKhronosGroup:masterfrom
alan-baker merged 2 commits intoKhronosGroup:masterfrom
Conversation
Contributor
Author
|
I'd like to get the assembler/disassembler support in reasonably quickly to facilitate the development/release of upcoming Vulkan and OpenCL extensions if possible. There is more work needed on validation and I'm happy to sign up to contribute this. I'm also fine with leaving the partial validation support out of this first PR if this helps with reducing the review burden. Let me know what you prefer. EDIT: The correspondind headers change is KhronosGroup/SPIRV-Headers#220 |
Collaborator
|
This works for me, as described at KhronosGroup/SPIRV-Headers#220 |
dneto0
approved these changes
Jun 23, 2021
Collaborator
|
This can only be merged when the headers PR is merged. (As close to simultaneously as practical.) |
- Adds new operand types for packed-vector-format - Moves ray tracing enums to the end - PackedVectorFormat is a new optional operand type, so it requires special handling in grammar table generation. - Add SPV_KHR_integer_dot_product to optimizer whitelists. - Pass-through validation: valid cases pass validation Validation errors are not checked. - Update SPIRV-Headers Patch by David Neto <dneto@google.com> Rebase and minor tweaks by Kevin Petit <kevin.petit@arm.com> Signed-off-by: David Neto <dneto@google.com> Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: Icb41741cb7f0f1063e5541ce25e5ba6c02266d2c
kpet
force-pushed
the
dneto-spv-khr-integer-dot-product
branch
from
1634fbf to
1c1c42d
Compare
Change-Id: I35c82ec27bded3d1b62373fa6daec3ffd91105a3
dneto0
approved these changes
Jun 23, 2021
Contributor
Author
|
The headers PR has gone in. I've rebased this change, updated DEPS and it now seems to be passing all automated tests. |
sliu-UIUC
pushed a commit
to sliu-UIUC/SPIRV-Tools
that referenced
this pull request
Jul 14, 2021
* Initial support for SPV_KHR_integer_dot_product - Adds new operand types for packed-vector-format - Moves ray tracing enums to the end - PackedVectorFormat is a new optional operand type, so it requires special handling in grammar table generation. - Add SPV_KHR_integer_dot_product to optimizer whitelists. - Pass-through validation: valid cases pass validation Validation errors are not checked. - Update SPIRV-Headers Patch by David Neto <dneto@google.com> Rebase and minor tweaks by Kevin Petit <kevin.petit@arm.com> Signed-off-by: David Neto <dneto@google.com> Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: Icb41741cb7f0f1063e5541ce25e5ba6c02266d2c * format fixes Change-Id: I35c82ec27bded3d1b62373fa6daec3ffd91105a3
10 tasks
alan-baker
pushed a commit
that referenced
this pull request
Jan 31, 2026
We seem to just have actually never added validation for `SPV_KHR_integer_dot_product` in #4327 (and seems after a few years, no one was going to do it) This adds it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new operand types for packed-vector-format
Moves ray tracing enums to the end
PackedVectorFormat is a new optional operand type, so it requires
special handling in grammar table generation.
Add SPV_KHR_integer_dot_product to optimizer whitelists.
Pass-through validation: valid cases pass validation
Validation errors are not checked.
Patch by David Neto dneto@google.com
Rebase and minor tweaks by Kevin Petit kevin.petit@arm.com
Signed-off-by: David Neto dneto@google.com
Signed-off-by: Kevin Petit kevin.petit@arm.com