Update Execution Mode argument name to match name in the SYCL extension#188
Merged
johnkslang merged 3 commits intoKhronosGroup:mainfrom Mar 1, 2023
Merged
Conversation
tiwaria1
changed the title
Contributor
Author
|
@MrSidims Could you review this minor change (I'll update the translator PR too) |
Collaborator
|
If we do this I think we'll want to update the grammar file and headers also (KhronosGroup/SPIRV-Headers#317). |
bashbaug
requested changes
Mar 1, 2023
Collaborator
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
If we do this please build an HTML spec with these changes as well.
Contributor
Author
|
@bashbaug I updated the html spec and the grammar file on the headers PR. Thank you for reviewing so quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argument name for the mode
RegisterMapInterfaceINTELin the SPIRV spec does not match the name in the SYCL extension(see property
register_map_interface). This PR updates the SPIRV extension to align the names.