Implementation of vector compute extension #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
In general the PR looks good to me. It is marked as draft. Are there anything else to be done? If not I suggest to push "Ready for review" button. |
Extension is published at intel/llvm#1611
Extension is published at intel/llvm#1612 Co-Authored-By: Aleksandr Bezzubikov <[email protected]> Co-Authored-By: Aleksander Us <[email protected]> Co-Authored-By: Alexey Sachkov <[email protected]> Co-Authored-By: Alexey Sotkin <[email protected]> Co-Authored-By: Anton Sidorenko <[email protected]> Co-Authored-By: Gang Chen <[email protected]> Co-Authored-By: Kai Chen <[email protected]> Co-Authored-By: Konstantin Vladimirov <[email protected]> Co-Authored-By: Wei Pan <[email protected]> Change-Id: Ic8bd645316f054729b8571efd2b9800a38cb723c
Contributor
AlexeySachkov
left a comment
AlexeySachkov
left a comment
There was a problem hiding this comment.
A few minor comments. Other than that, looks good to me
lib/SPIRV/SPIRVReader.cpp
Outdated
| F->addAttribute(AttributeList::FunctionIndex, Attr); | ||
| } | ||
|
|
||
| if (F->getCallingConv() != CallingConv::SPIR_KERNEL) |
Contributor
There was a problem hiding this comment.
What is the point of this if if we anyway return true below?
Contributor
Author
There was a problem hiding this comment.
An artifact of previous revisions. Fixed.
lib/SPIRV/VectorComputeUtil.cpp
Outdated
| // This file is distributed under the University of Illinois Open Source | ||
| // License. See LICENSE.TXT for details. | ||
| // | ||
| // Copyright (c) 2018 Intel Corporation. All rights reserved. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2018 Intel Corporation. All rights reserved. | |
| // Copyright (c) 2020 Intel Corporation. All rights reserved. |
lib/SPIRV/VectorComputeUtil.h
Outdated
| // This file is distributed under the University of Illinois Open Source | ||
| // License. See LICENSE.TXT for details. | ||
| // | ||
| // Copyright (c) 2018 Intel Corporation. All rights reserved. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2018 Intel Corporation. All rights reserved. | |
| // Copyright (c) 2020 Intel Corporation. All rights reserved. |
lib/SPIRV/VectorComputeUtil.h
Outdated
| #include "SPIRVInternal.h" | ||
| #include "SPIRVUtil.h" | ||
| #include "spirv.hpp" | ||
| #include "llvm/IR/Module.h" |
Contributor
There was a problem hiding this comment.
Suggested change
| #include "llvm/IR/Module.h" |
| @@ -0,0 +1,32 @@ | |||
| ; RUN: llvm-as %s -o %t.bc | |||
| ; RUN: llvm-spirv %t.bc -o %t.spv --spirv-ext=+SPV_INTEL_vector_compute --spirv-ext=+SPV_KHR_float_controls --spirv-ext=+SPV_INTEL_float_controls2 | |||
Contributor
There was a problem hiding this comment.
Suggested change
| ; RUN: llvm-spirv %t.bc -o %t.spv --spirv-ext=+SPV_INTEL_vector_compute --spirv-ext=+SPV_KHR_float_controls --spirv-ext=+SPV_INTEL_float_controls2 | |
| ; RUN: llvm-spirv %t.bc -o %t.spv --spirv-ext=+SPV_INTEL_vector_compute,+SPV_KHR_float_controls,+SPV_INTEL_float_controls2 |
| @@ -0,0 +1,36 @@ | |||
| ; RUN: llvm-as %s -o %t.bc | |||
Contributor
There was a problem hiding this comment.
Since these tests are performing both direct and reverse translation, could you please move them into transcoding folder?
Backend part Extension is published at intel/llvm#1612 Co-Authored-By: Aleksandr Bezzubikov <[email protected]> Co-Authored-By: Aleksander Us <[email protected]> Co-Authored-By: Alexey Sachkov <[email protected]> Co-Authored-By: Alexey Sotkin <[email protected]> Co-Authored-By: Anton Sidorenko <[email protected]> Co-Authored-By: Gang Chen <[email protected]> Co-Authored-By: Kai Chen <[email protected]> Co-Authored-By: Konstantin Vladimirov <[email protected]> Co-Authored-By: Wei Pan <[email protected]> Change-Id: Ic8bd645316f054729b8571efd2b9800a38cb723c
Frontend part Extension is published at intel/llvm#1612 Co-Authored-By: Aleksandr Bezzubikov <[email protected]> Co-Authored-By: Aleksander Us <[email protected]> Co-Authored-By: Alexey Sachkov <[email protected]> Co-Authored-By: Alexey Sotkin <[email protected]> Co-Authored-By: Anton Sidorenko <[email protected]> Co-Authored-By: Gang Chen <[email protected]> Co-Authored-By: Kai Chen <[email protected]> Co-Authored-By: Konstantin Vladimirov <[email protected]> Co-Authored-By: Wei Pan <[email protected]> Change-Id: Ic8bd645316f054729b8571efd2b9800a38cb723c
SPV_INTEL_float_controls2 and SPV_KHR_float_controls extensions Extensions are published at intel/llvm#1612 intel/llvm#1611
AlexeySotkin
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensions are published at intel/llvm#1612 and intel/llvm#1611