[NFC] Remove legacy joint matrix instructions#3438
[NFC] Remove legacy joint matrix instructions#3438MrSidims merged 5 commits intoKhronosGroup:mainfrom
Conversation
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
MrSidims
force-pushed
the
remove-joint-matrix
branch
from
ed56c7d to
6174a53
Compare
| _SPIRV_OP(Capability, JointMatrixPackedInt2ComponentTypeINTEL) | ||
| _SPIRV_OP(Capability, JointMatrixPackedInt4ComponentTypeINTEL) |
There was a problem hiding this comment.
What about PackedCooperativeMatrixINTEL capability?
There was a problem hiding this comment.
They no longer present in our specification. Added a link in PR description actually
There was a problem hiding this comment.
It is present in the PR you added in description - guess the spec needs to be fixed
There was a problem hiding this comment.
Does it? Don't be confused by PackedINTEL - it's for VNNI layout of a matrix in memory. Int2/Int4 is typed interpretation for matrix elements.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, I see that.
I mean that we maybe need to add capability PackedCooperativeMatrixINTEL to the headers as it is listed in the specification and allows to use this PackedINTEL matrix layout
There was a problem hiding this comment.
Ok, I'll add it in a separate PR. Please resolve conflicts to merge this one
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
2 participants
Brand-new spec: intel/llvm#12497