Refactoring Two functions into One#3124
Merged
MrSidims merged 1 commit intoKhronosGroup:mainfrom Apr 23, 2025
Merged
Conversation
Contributor
EbinJose2002
commented
Apr 18, 2025
EbinJose2002
commented
- Refactored addUntypedPointerKHRType and addPointerType functions into a single function (It was marked as TODO)
- Combined both functions into one with return type SPIRVType *
- Also re inserted an assert and removed unnecessary if (Marked as TODO)
MrSidims
approved these changes
Apr 22, 2025
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
LGTM, but lets hold the merge for a while, so we could fix the CI first
vmaksimo
approved these changes
Apr 22, 2025
lib/SPIRV/SPIRVWriter.cpp
Outdated
Comment on lines
2352
to
2353
| // TODO: refactor addPointerType and addUntypedPointerKHRType in one | ||
| // method if possible. |
- Combined both functions into one with return type SPIRVType * - Also re inserted an assert and removed unnecessary if
EbinJose2002
force-pushed
the
pointer_type
branch
from
f557d7f to
61fd46a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.