[SPIR-V 1.2] SPIRVReader: Add MaxByteOffsetId support #2884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration.
MrSidims
approved these changes
Nov 28, 2024
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 29, 2024
KhronosGroup#2884) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 29, 2024
KhronosGroup#2884) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 29, 2024
KhronosGroup#2884) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 29, 2024
KhronosGroup#2884) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 29, 2024
KhronosGroup#2884) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 29, 2024
KhronosGroup#2884) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 29, 2024
KhronosGroup#2884) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
that referenced
this pull request
Dec 2, 2024
#2884) (#2897) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
that referenced
this pull request
Dec 2, 2024
#2884) (#2896) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
that referenced
this pull request
Dec 2, 2024
#2884) (#2895) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
that referenced
this pull request
Dec 2, 2024
#2884) (#2894) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
that referenced
this pull request
Dec 2, 2024
#2884) (#2893) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
svenvh
added a commit
that referenced
this pull request
Dec 2, 2024
#2884) (#2892) If there is no `OpDecorate .. MaxByteOffset` in the input, see if there is an `OpDecorateId .. MaxByteOffsetId` and take the value for the LLVM `dereferenceable` attribute from the referenced constant instead. Once `MaxByteOffsetId` has been translated to LLVM IR, it is indistinguishable from a (non-ID) `MaxByteOffset` decoration. (cherry picked from commit 0332a1e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no
OpDecorate .. MaxByteOffsetin the input, see if there is anOpDecorateId .. MaxByteOffsetIdand take the value for the LLVMdereferenceableattribute from the referenced constant instead.Once
MaxByteOffsetIdhas been translated to LLVM IR, it is indistinguishable from a (non-ID)MaxByteOffsetdecoration.