[OpaquePointers] Rewrite joint_matrix tests #2088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jcranmer-intel @vmaksimo please take a look |
This patch adds joint_matrix reverse translation to target extension type and starts rewriting all of the tests. Some tests are being removed as outdated Remaining tests to add after the patch: 1. tf32 test 2. element wise operations test Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims
force-pushed
the
joint-matrix-opaque
branch
from
1e65e2f to
ab0aeaf
Compare
vmaksimo
reviewed
Jul 20, 2023
lib/SPIRV/SPIRVReader.cpp
Outdated
| switch (static_cast<SPIRVConstant *>(CTI)->getZExtIntValue()) { | ||
| case internal::InternalJointMatrixCTI::TF32: | ||
| ComponentTypeName = "tf32"; | ||
| Params.push_back(1); |
Contributor
There was a problem hiding this comment.
Do we have some enum for these values?
Contributor
Author
There was a problem hiding this comment.
Oh, we do have them :) it is "internal::InternalJointMatrixCTI::"
Contributor
|
Ah. I see that we are running into 'opaque-pointers=0' not available errors in our CI. How do we intend to work around this or tackle this? Thanks |
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
jcranmer-intel
approved these changes
Jul 21, 2023
fda0
pushed a commit
to fda0/SPIRV-LLVM-Translator
that referenced
this pull request
May 22, 2025
…Group#2088) This patch adds joint_matrix reverse translation to target extension type and starts rewriting all of the tests. Some tests are being removed as outdated Remaining tests to add after the patch: 1. tf32 test 2. element wise operations test Signed-off-by: Sidorov, Dmitry <[email protected]> (cherry picked from commit 465eb3c)
bokrzesi
pushed a commit
to bokrzesi/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 10, 2025
…Group#2088) This patch adds joint_matrix reverse translation to target extension type and starts rewriting all of the tests. Some tests are being removed as outdated Remaining tests to add after the patch: 1. tf32 test 2. element wise operations test Signed-off-by: Sidorov, Dmitry <[email protected]> (cherry picked from commit 465eb3c)
bokrzesi
pushed a commit
to bokrzesi/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 11, 2025
This patch adds joint_matrix reverse translation to target extension type and starts rewriting all of the tests. Some tests are being removed as outdated Remaining tests to add after the patch: 1. tf32 test 2. element wise operations test Signed-off-by: Sidorov, Dmitry <[email protected]> (cherry picked from commit 465eb3c)
bokrzesi
pushed a commit
to bokrzesi/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 11, 2025
This patch adds joint_matrix reverse translation to target extension type and starts rewriting all of the tests. Some tests are being removed as outdated Remaining tests to add after the patch: 1. tf32 test 2. element wise operations test Signed-off-by: Sidorov, Dmitry <[email protected]> (cherry picked from commit 465eb3c)
bokrzesi
added a commit
to bokrzesi/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 11, 2025
This reverts commit 8462b72.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds joint_matrix reverse translation to target extension type and starts rewriting all of the tests.
Some tests are being removed as outdated
Remaining tests to add after the patch: