Skip to content

Conversation

@vmaksimo
Copy link
Contributor

@vmaksimo vmaksimo commented May 4, 2023

Max length of SPIRV instruction is 65535 words by specification.
DebugSourceContinued helps to overcome the limitation and specify full source code text by continuing the string from the previous DebugSource(Continued)instruction.

Spec:
https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugSourceContinued

@vmaksimo
Copy link
Contributor Author

vmaksimo commented May 4, 2023

@MrSidims @asudarsa @maksimsab @jgstarIntel @LU-JOHN please take a look

Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good, thanks!
@vmaksimo Please update the description, what these instructions do and what is 'number of Words limitation' SPIR-V spec puts on the instructions

@MrSidims MrSidims merged commit aabcaf8 into KhronosGroup:main May 5, 2023
MrSidims pushed a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Jun 16, 2023
…#1993)

Max length of SPIRV instruction is 65535 words by specification.
DebugSourceContinued helps to overcome the limitation and specify full source code text by continuing the string from the previous DebugSource(Continued)instruction.

Spec:
https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugSourceContinued
MrSidims pushed a commit that referenced this pull request Jun 19, 2023
Max length of SPIRV instruction is 65535 words by specification.
DebugSourceContinued helps to overcome the limitation and specify full source code text by continuing the string from the previous DebugSource(Continued)instruction.

Spec:
https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugSourceContinued
vmaksimo added a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this pull request Jun 27, 2023
…#1993)

Max length of SPIRV instruction is 65535 words by specification.
DebugSourceContinued helps to overcome the limitation and specify full source code text by continuing the string from the previous DebugSource(Continued)instruction.

Spec:
https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugSourceContinued
MrSidims pushed a commit that referenced this pull request Jul 3, 2023
Max length of SPIRV instruction is 65535 words by specification.
DebugSourceContinued helps to overcome the limitation and specify full source code text by continuing the string from the previous DebugSource(Continued)instruction.

Spec:
https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugSourceContinued
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants