[DebugInfo] Initial support NonSemantic.Kernel.DebugInfo.100#1846
Merged
MrSidims merged 5 commits intoKhronosGroup:mainfrom Feb 20, 2023
Merged
[DebugInfo] Initial support NonSemantic.Kernel.DebugInfo.100#1846MrSidims merged 5 commits intoKhronosGroup:mainfrom
MrSidims merged 5 commits intoKhronosGroup:mainfrom
Conversation
This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186
Contributor
|
@svenvh may I ask you to take a look if you (ARM) would be interested in new debug info extended instruction set? |
MrSidims
reviewed
Feb 13, 2023
MrSidims
reviewed
Feb 14, 2023
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
Follow up to the comment to the test:
I see some W/As to preserve subranges in existing DebugTypeArray translation. I suggest not to remove these W/As: instead we may have (temporary) two version of translate DebugTypeArray functions:
- 1st should be the same implementation as we have now without the patch, and they should be run if OpenCL debug info instruction set is enabled;
- 2nd should be the changed functions as they are being added in this patch, and they should be run if nonsemantic debug info instruction set is enabled
MrSidims
reviewed
Feb 20, 2023
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
Overall LGTM, several minor comments
test/FortranArray.ll
Outdated
| ; and back to .ll. This causes the LLVM IR verifier to fail as there | ||
| ; are different rules for valid DISubRange depending on language ID. | ||
|
|
||
| ; RUN: llvm-spirv %t.bc -spirv-text --spirv-debug-info-version=nonsemantic-kernel-100 |
Contributor
There was a problem hiding this comment.
Lets don't change this test in this patch
Contributor
Author
There was a problem hiding this comment.
Why not? We just add the run/check lines for new behavior for DISubrange. Or do we plan to preserve only one version of DISubrange translation?
Contributor
There was a problem hiding this comment.
The problem here is with the Fortran language. As we discussed offline, the lower bound can start from either 0 or 1 depending on the language. So for the older spec, we won't have Fortran language, which means that after the translation, we will have OpenCL encoded in dwarf. In this test, the lower bound seems to be set as 1, causing the LLVM verifier to error out.
Contributor
|
Merging do unblock further development. Name of the instruction set and option can be changed. |
aratajew
pushed a commit
to aratajew/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 29, 2023
This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186
aratajew
pushed a commit
to aratajew/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 29, 2023
This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186
MrSidims
changed the title
stanleygambarin
pushed a commit
to stanleygambarin/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 30, 2023
…ronosGroup#1846) This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186
stanleygambarin
pushed a commit
to stanleygambarin/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 30, 2023
…onosGroup#1846) This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186
MrSidims
pushed a commit
that referenced
this pull request
Mar 31, 2023
This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186
MrSidims
pushed a commit
that referenced
this pull request
Apr 3, 2023
) This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186
mateuszchudyk
pushed a commit
to mateuszchudyk/SPIRV-LLVM-Translator
that referenced
this pull request
May 10, 2023
…ronosGroup#1846) This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186
mateuszchudyk
pushed a commit
to mateuszchudyk/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 29, 2023
…ronosGroup#1846) This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186
MrSidims
pushed a commit
that referenced
this pull request
Oct 5, 2023
) This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100.
It also introduces support for the new debug instruction DISubrange.
Spec: KhronosGroup/SPIRV-Registry#186