[OpaquePointers] Improvements to the type scavenger.#1775
Merged
MrSidims merged 2 commits intoKhronosGroup:mainfrom Jan 4, 2023
Merged
[OpaquePointers] Improvements to the type scavenger.#1775MrSidims merged 2 commits intoKhronosGroup:mainfrom
MrSidims merged 2 commits intoKhronosGroup:mainfrom
Conversation
jcranmer-intel
force-pushed
the
type-scavenge-intrinsics
branch
2 times, most recently
from
0092709 to
4ed2e4e
Compare
Contributor
|
Closing/reopening to restart CI with a new base |
Contributor
|
@jcranmer-intel it seems like CI failures are related to the patch, could you please take a look? |
The main improvement is to enable intrinsics with more complex typing rules to be described. For example, memcpy's requirement that its two pointer arguments have the same type. There is still a larger rewrite of the type scavenger to use TypedPointerType coming down the line. However, this rewrite also needs opaque types to represent the deferred type concept, which is why it hasn't been done yet. This is an intermediate step in the rewrite which better supports some of the other intrinsics with current issues.
jcranmer-intel
force-pushed
the
type-scavenge-intrinsics
branch
from
4ed2e4e to
f62e5c8
Compare
svenvh
approved these changes
Jan 3, 2023
MrSidims
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main improvement is to enable intrinsics with more complex typing rules to be described. For example, memcpy's requirement that its two pointer arguments have the same type.
There is still a larger rewrite of the type scavenger to use TypedPointerType coming down the line. However, this rewrite also needs opaque types to represent the deferred type concept, which is why it hasn't been done yet. This is an intermediate step in the rewrite which better supports some of the other intrinsics with current issues.