Catch up with llvm/llvm-project@9114ac67a986400155b8b82013d09a9e4f48e534#1765
Conversation
|
|
|
@arichardson thanks a lot! Just started looking at https://reviews.llvm.org/D138722 |
|
I believe a follow-up change would be to use the Constant address space for the global strings, but since I don't understand the required semantics here I did not include that in this PR. |
There was a problem hiding this comment.
LGTM
@arichardson please apply clang tidy suggestion
arichardson
force-pushed
the
annotation-intrinsics-llvm-16
branch
from
ac9a869 to
db06f54
Compare
Done. I guess the CI failures are caused by the builders using an older LLVM snapshot? |
Yeap, we can ignore them. in-tree builds and testing are more important in this case. |
The ptr_annotation/var_annotation/annotation intrinsics gained additional overloads which means we have to update calls to Intrinsic::getDeclaration()/Builder.CreateIntrinsic().
arichardson
force-pushed
the
annotation-intrinsics-llvm-16
branch
from
db06f54 to
a9f4fec
Compare
Ah actually there were two clang-tidy warnings but it seems like only the first one showed up in the log. Fixed the second one now. |
3 participants
The ptr_annotation/var_annotation/annotation intrinsics gained additional overloads which means we have to update calls to Intrinsic::getDeclaration()/Builder.CreateIntrinsic().