Integer dot product 4x8 packed translation#1633
Merged
svenvh merged 1 commit intoKhronosGroup:mainfrom Oct 12, 2022
Merged
Conversation
Quetzonarch
force-pushed
the
integer-dot-product-packed
branch
from
5711805 to
8a393f7
Compare
Changed the integer dot translation to use the correct function names (i.e. dot_4x8packed or dot_acc_sat_4x8packed) to translate them into proper OpCodes. Additionally removed unused variables from visitCallDot
Quetzonarch
force-pushed
the
integer-dot-product-packed
branch
from
8a393f7 to
603cd82
Compare
MrSidims
approved these changes
Oct 11, 2022
svenvh
approved these changes
Oct 12, 2022
This was referenced Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposed bugfix updates the integer dot translation to use the correct function names from the OpenCL extension specification for packed format with scalar integer arguments (i.e. dot_4x8packed or dot_acc_sat_4x8packed instead of dot or dot_acc_sat with scalar integer arguments) to translate them into proper OpCodes. This is a fix for incorrect function names introduced in #1174
Additionally removed unused variables from visitCallDot to clean up the code.
Link to OpenCL spec:
https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#cl_khr_integer_dot_product