Fix parsing of --spec-const option #1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
launching llvm-spirv with arguments: -r --spec-const=101:i64:4609589727908835759 results in error message: Error: Invalid value for '-spec-const' option! In "101:i64:4609589727908835759": can't convert "4609589727908835759" to 64-bit integer number However, 4609589727908835759 fits into 64bits. The problem is that getNumWords() returns 2 so instead change the check to use getActiveBits()
|
|
|
Thanks for the report and the PR, that is very appreciated! Could you please add a small test (may be modify transcoding/spec_const.ll ) so we can ensure, that the issue is gone? TBH I'm very surprised by the fact, that getNumWords() returns 2 for 4609589727908835759 . |
svenvh
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
TBH I'm very surprised by the fact, that getNumWords() returns 2 for 4609589727908835759 .
Me too, so I did a little investigation. It turns out StringRef::getAsInteger deliberately overestimates the required number of bits based on the radix and the string length.
So getActiveWords is the right method to use here. Thanks for the fix!
MrSidims
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running OpenCL-CTS SPIR-V subtests, i found that launching llvm-spirv with arguments:
-r --spec-const=101:i64:4609589727908835759results in error message:
Error: Invalid value for '-spec-const' option! In "101:i64:4609589727908835759": can't convert "4609589727908835759" to 64-bit integer numberHowever, 4609589727908835759 fits into 64bits (0x3ff88d6f544bb1af). The problem seems to be that getNumWords() returns 2 so i changed it to use getActiveBits(), but i'm not 100% sure this is the proper fix.