Skip to content

Add ExecutionModeNamedBarrierCountINTEL #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2022
Merged

Add ExecutionModeNamedBarrierCountINTEL #1595

merged 1 commit into from
Aug 23, 2022

Conversation

@vmustya
Copy link
Contributor

@vmustya vmustya commented Aug 23, 2022

No description provided.

MrSidims
MrSidims reviewed Aug 23, 2022
View reviewed changes
@MrSidims
Copy link
Contributor

MrSidims commented Aug 23, 2022

@vmustya hi, where can we ready about this extension? Also the test for the feature is missing.

@vmustya
Copy link
Contributor Author

vmustya commented Aug 23, 2022

@vmustya hi, where can we ready about this extension? Also the test for the feature is missing.

This stuff is a part of SPV_INTEL_vector_compute extension: https://github.com/intel/llvm/blob/68def46184daa35d7819793b3a3eed733ee27137/sycl/doc/extensions/SPIRV/SPV_INTEL_vector_compute.asciidoc

@vmustya vmustya requested a review from MrSidims August 23, 2022 12:24
MrSidims
MrSidims reviewed Aug 23, 2022
View reviewed changes
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 nits

@vmustya vmustya force-pushed the vc-nbarrier-main branch 2 times, most recently from 1148dcf to 7738970 Compare August 23, 2022 12:35
@vmustya vmustya requested a review from MrSidims August 23, 2022 12:36
MrSidims
MrSidims reviewed Aug 23, 2022
View reviewed changes
@vmustya vmustya force-pushed the vc-nbarrier-main branch 2 times, most recently from e9c585c to 3f4ce6d Compare August 23, 2022 13:58
@MrSidims MrSidims merged commit 21c7a30 into KhronosGroup:main Aug 23, 2022
@bashbaug
Copy link
Contributor

bashbaug commented Aug 23, 2022

Do we need ExecutionModeNamedBarrierCountINTEL to be in the "internal" namespace? It looks like it's in the upstream headers already.

https://github.com/KhronosGroup/SPIRV-Headers/blob/master/include/spirv/unified1/spirv.hpp#L193

@MrSidims
Copy link
Contributor

MrSidims commented Aug 23, 2022

Do we need ExecutionModeNamedBarrierCountINTEL to be in the "internal" namespace? It looks like it's in the upstream headers already.

https://github.com/KhronosGroup/SPIRV-Headers/blob/master/include/spirv/unified1/spirv.hpp#L193

My bad. Let me fix in on the main branch. @vmustya could you please adjust the rest of PRs.

@MrSidims
Copy link
Contributor

MrSidims commented Aug 23, 2022

Thanks Ben! Done in #1604

@vmustya vmustya deleted the vc-nbarrier-main branch August 26, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrSidims MrSidims MrSidims approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vmustya @MrSidims @bashbaug @NikitaRudenkoIntel