Skip to content

Dot product bugfix to include more floating point types #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svenvh merged 3 commits into from
Aug 22, 2022
Merged

Dot product bugfix to include more floating point types #1578

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49b2415
Dot product bugfix
Quetzonarch Aug 16, 2022
1bcf1c1
Dot product bugfix - added test
Quetzonarch Aug 17, 2022
5b70a38
Dot product bugfix - suggested changes
Quetzonarch Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/SPIRV/OCLToSPIRV.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,8 @@ void OCLToSPIRVBase::visitCallInst(CallInst &CI) {
return;
}
if (DemangledName == kOCLBuiltinName::Dot &&
(CI.getOperand(0)->getType()->isFloatTy() ||
CI.getOperand(1)->getType()->isDoubleTy())) {
(!CI.getOperand(0)->getType()->isVectorTy() &&
!CI.getOperand(0)->getType()->isIntegerTy())) {

@svenvh svenvh Aug 16, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if just CI.getOperand(0)->getType()->isFPOrFPVectorTy() is sufficient?

@Quetzonarch Quetzonarch Aug 17, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand this visitCallDot is meant to translate dot with scalar floating point arguments (but not vectors) into FMul. Because of that FPVectors shouldn't pass this check but instead stay as calls to dot.

@jcranmer-intel jcranmer-intel Aug 17, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isFloatingPointTy()?

@Quetzonarch Quetzonarch Aug 18, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that might be a good idea

visitCallDot(&CI);
return;
}
Expand Down