[Backport] Implement SPV_INTEL_debug_module extension (#1089) (#1520) #1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszchudyk
force-pushed
the
backport-implement-spv-intel-debug-module-ext-llvm110
branch
2 times, most recently
from
5bf2a72 to
ac33b41
Compare
* Implement SPV_INTEL_debug_module extension Spec intel/llvm#3976
mateuszchudyk
force-pushed
the
backport-implement-spv-intel-debug-module-ext-llvm110
branch
from
4e2527e to
3adc6d7
Compare
Contributor
Author
|
All required builds passed but one. In this case the problem is in the build command not in the patch. I described it here: #1546. |
svenvh
approved these changes
Jul 12, 2022
Member
svenvh
left a comment
svenvh
left a comment
There was a problem hiding this comment.
All required builds passed but one. In this case the problem is in the build command not in the patch. I described it here: #1546.
Thanks, I've seen that failing before but not quite sure what's causing it. Shouldn't block merging this PR indeed.
mateuszchudyk
deleted the
backport-implement-spv-intel-debug-module-ext-llvm110
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of implementation of SPV_INTEL_debug_module extension (#1089). Few small changes compared to the origin patch (2b3a2f3) due to differences between llvm11 and llvm13+.