Support SPV_INTEL_non_constant_addrspace_printf #1364

KornevNikita · 2021-12-28T17:18:14Z

Spec: intel/llvm#5227

KornevNikita · 2022-01-15T15:00:11Z

@AlexeySotkin @MrSidims @AlexeySachkov take a look please

lib/SPIRV/SPIRVWriter.cpp

MrSidims

LGTM

test/transcoding/SPV_INTEL_non_constant_addrspace_printf/non-constant-printf.ll

AlexeySotkin · 2022-02-03T14:58:43Z

@KornevNikita please resolve the merge conflicts.

KornevNikita · 2022-02-03T15:39:31Z

@AlexeySotkin thanks, done.

KornevNikita · 2022-02-04T08:42:13Z

Retrigger tests

test/transcoding/SPV_INTEL_non_constant_addrspace_printf/non-constant-printf.ll

Spec: intel/llvm#5227 (cherry picked from commit 6e70d1c)

Spec: intel/llvm#5227

…ntf (KhronosGroup#1364) '"master"' -> '"xmain-web"' (32 commits) CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/spirv_internal.hpp CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h CONFLICT (content): Merge conflict in include/LLVMSPIRVExtensions.inc commit 6e70d1c Author: Nikita <[email protected]> Date: Mon Feb 28 13:24:49 2022 +0300 Support SPV_INTEL_non_constant_addrspace_printf (KhronosGroup#1364) Spec: intel/llvm#5227

…drspace_printf (KhronosGroup#1364) '"master"' -> '"xmain-web"' (32 commits) (KhronosGroup#138) * Resolve of merge (conflict) 6e70d1c Support SPV_INTEL_non_constant_addrspace_printf (KhronosGroup#1364) '"master"' -> '"xmain-web"' (32 commits) CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/spirv_internal.hpp CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h CONFLICT (content): Merge conflict in include/LLVMSPIRVExtensions.inc commit 6e70d1c Author: Nikita <[email protected]> Date: Mon Feb 28 13:24:49 2022 +0300 Support SPV_INTEL_non_constant_addrspace_printf (KhronosGroup#1364) Spec: intel/llvm#5227 * Conflict resolution Co-authored-by: iclsrc <[email protected]> Co-authored-by: Dmitry Sidorov <[email protected]>

…nstant_addrspace_printf (KhronosGroup#1364) '"master"' -> '"xmain-web"' (32 commits) (KhronosGroup#138) * Resolve of merge (conflict) 6e70d1c Support SPV_INTEL_non_constant_addrspace_printf (KhronosGroup#1364) '"master"' -> '"xmain-web"' (32 commits) CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/spirv_internal.hpp CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h CONFLICT (content): Merge conflict in include/LLVMSPIRVExtensions.inc commit 6e70d1c Author: Nikita <[email protected]> Date: Mon Feb 28 13:24:49 2022 +0300 Support SPV_INTEL_non_constant_addrspace_printf (KhronosGroup#1364) Spec: intel/llvm#5227 * Conflict resolution Co-authored-by: iclsrc <[email protected]> Co-authored-by: Dmitry Sidorov <[email protected]>

…extension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148

…xtension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148

…extension (#1819) This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148

…extension (#1820) This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148

…xtension (#1821) This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148

…xtension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148

…xtension This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148

…extension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818

…extension (#1867) This backport is a squash of #1364, #1749, #1818

…extension (#1866) This backport is a squash of #1364, #1749, #1818

KornevNikita added 3 commits December 28, 2021 20:16

Support SPV_INTEL_non_constant_addrspace_printf

919bf30

Spec: intel/llvm#5227

Fix clang-format

48e04cf

Update opcode

d536ccc

KornevNikita marked this pull request as ready for review January 15, 2022 13:45

mlychkov reviewed Jan 20, 2022

View reviewed changes

lib/SPIRV/SPIRVWriter.cpp Outdated Show resolved Hide resolved

Apply suggestion

3acbfb9

AlexeySachkov mentioned this pull request Jan 21, 2022

[SYCLLowerIR] Promote i8 and i16 arguments in MutatePrintfAddrspace intel/llvm#5331

Closed

MrSidims approved these changes Jan 28, 2022

View reviewed changes

AlexeySotkin approved these changes Jan 28, 2022

View reviewed changes

AlexeySotkin reviewed Jan 31, 2022

View reviewed changes

test/transcoding/SPV_INTEL_non_constant_addrspace_printf/non-constant-printf.ll Outdated Show resolved Hide resolved

KornevNikita added 4 commits February 2, 2022 13:56

Fix reverse

5457fbb

Fix clang format

f7f2247

Fix lit

8e421f5

Fix out-of-tree warning

ecdd28c

Merge branch 'master' into printf

3a11614

KornevNikita closed this Feb 4, 2022

KornevNikita reopened this Feb 4, 2022

AlexeySotkin reviewed Feb 18, 2022

View reviewed changes

test/transcoding/SPV_INTEL_non_constant_addrspace_printf/non-constant-printf.ll Outdated Show resolved Hide resolved

KornevNikita added 2 commits February 18, 2022 16:14

Disable OCL mangling

20afae4

Fix test

dfd0989

AlexeySotkin requested review from AlexeySachkov, AlexeySotkin and MrSidims February 18, 2022 13:29

AlexeySachkov approved these changes Feb 22, 2022

View reviewed changes

test/transcoding/SPV_INTEL_non_constant_addrspace_printf/non-constant-printf.ll Outdated Show resolved Hide resolved

Apply suggestion

39db81d

AlexeySotkin approved these changes Feb 28, 2022

View reviewed changes

AlexeySotkin merged commit 6e70d1c into KhronosGroup:master Feb 28, 2022

KornevNikita deleted the printf branch March 29, 2022 08:16

svenvh pushed a commit to svenvh/SPIRV-LLVM-Translator that referenced this pull request Jun 21, 2022

Support SPV_INTEL_non_constant_addrspace_printf (KhronosGroup#1364)

731733d

Spec: intel/llvm#5227 (cherry picked from commit 6e70d1c)

svenvh pushed a commit that referenced this pull request Jun 22, 2022

Support SPV_INTEL_non_constant_addrspace_printf (#1364)

25ef58e

Spec: intel/llvm#5227 (cherry picked from commit 6e70d1c)

Quetzonarch pushed a commit to Quetzonarch/SPIRV-LLVM-Translator that referenced this pull request Jul 13, 2022

Support SPV_INTEL_non_constant_addrspace_printf (KhronosGroup#1364)

08c16b4

Spec: intel/llvm#5227

This was referenced Jan 23, 2023

[Backport to 11] Support SPV_EXT_relaxed_printf_string_address_space extension #1819

Merged

[Backport to 10] Support SPV_EXT_relaxed_printf_string_address_space extension #1820

Merged

vmaksimo mentioned this pull request Jan 23, 2023

[Backport to 9] Support SPV_EXT_relaxed_printf_string_address_space extension #1821

Merged

vmaksimo mentioned this pull request Jan 23, 2023

[Backport to 8] Support SPV_EXT_relaxed_printf_string_address_space extension #1822

Closed

MrSidims pushed a commit that referenced this pull request Jan 24, 2023

[Backport to 11] Support SPV_EXT_relaxed_printf_string_address_space …

9991d09

…extension (#1819) This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148

MrSidims pushed a commit that referenced this pull request Jan 24, 2023

[Backport to 10] Support SPV_EXT_relaxed_printf_string_address_space …

6441ca1

…extension (#1820) This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148

MrSidims pushed a commit that referenced this pull request Jan 26, 2023

[Backport to 9] Support SPV_EXT_relaxed_printf_string_address_space e…

fb651fb

…xtension (#1821) This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148

vmaksimo mentioned this pull request Feb 3, 2023

[Backport to 8] Support SPV_EXT_relaxed_printf_string_address_space extension #1832

Merged

MrSidims pushed a commit that referenced this pull request Feb 8, 2023

[Backport to 8] Support SPV_EXT_relaxed_printf_string_address_space e…

18ce1b5

…xtension This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148

vmaksimo added a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this pull request Mar 3, 2023

[Backport to 13] Support SPV_EXT_relaxed_printf_string_address_space …

fed20e4

…extension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818

vmaksimo mentioned this pull request Mar 3, 2023

[Backport to 13] Support SPV_EXT_relaxed_printf_string_address_space extension #1866

Merged

vmaksimo added a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this pull request Mar 3, 2023

[Backport to 12] Support SPV_EXT_relaxed_printf_string_address_space …

505298a

…extension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818

vmaksimo mentioned this pull request Mar 3, 2023

[Backport to 12] Support SPV_EXT_relaxed_printf_string_address_space extension #1867

Merged

MrSidims pushed a commit that referenced this pull request Mar 6, 2023

[Backport to 12] Support SPV_EXT_relaxed_printf_string_address_space …

f3d5411

…extension (#1867) This backport is a squash of #1364, #1749, #1818

MrSidims pushed a commit that referenced this pull request Mar 6, 2023

[Backport to 13] Support SPV_EXT_relaxed_printf_string_address_space …

759f76b

…extension (#1866) This backport is a squash of #1364, #1749, #1818

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support SPV_INTEL_non_constant_addrspace_printf #1364

Support SPV_INTEL_non_constant_addrspace_printf #1364

Uh oh!

KornevNikita commented Dec 28, 2021

Uh oh!

KornevNikita commented Jan 15, 2022

Uh oh!

Uh oh!

MrSidims left a comment

Uh oh!

Uh oh!

AlexeySotkin commented Feb 3, 2022

Uh oh!

KornevNikita commented Feb 3, 2022

Uh oh!

KornevNikita commented Feb 4, 2022

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Support SPV_INTEL_non_constant_addrspace_printf #1364

Support SPV_INTEL_non_constant_addrspace_printf #1364

Uh oh!

Conversation

KornevNikita commented Dec 28, 2021

Uh oh!

KornevNikita commented Jan 15, 2022

Uh oh!

Uh oh!

MrSidims left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexeySotkin commented Feb 3, 2022

Uh oh!

KornevNikita commented Feb 3, 2022

Uh oh!

KornevNikita commented Feb 4, 2022

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants