Add support for SPV_INTEL_joint_matrix extension#1165
Merged
AlexeySotkin merged 5 commits intoKhronosGroup:masterfrom Aug 26, 2021
Merged
Add support for SPV_INTEL_joint_matrix extension#1165AlexeySotkin merged 5 commits intoKhronosGroup:masterfrom
AlexeySotkin merged 5 commits intoKhronosGroup:masterfrom
Conversation
lib/SPIRV/SPIRVRegularizeLLVM.cpp
Outdated
Comment on lines
317
to
321
| if (size_t Space = ElemType.rfind(' ')) | ||
| ElemType = ElemType.substr(Space + 1); |
Contributor
There was a problem hiding this comment.
What if there are no space? In which cases you expect the condition to return false?
Contributor
Author
There was a problem hiding this comment.
It is ok if there is no space. This if handles cases when we have type modifier, like in the example signed char. In this case we take only last word "char". If there is no space it means that there is no modifiers and ElemType already holds the name of the type we want.
Contributor
There was a problem hiding this comment.
Note that if there is no space, rfind returns npos, which evaluates to true, which means that ElemType will be overwritten (I assume with an empty string)
The spec is available at intel/llvm#4373
Clean up SPIRVRegularizeLLVMBase::adaptStructTypes method Add clarifying comments Signed-off-by: Alexey Sotkin <alexey.sotkin@intel.com>
AlexeySotkin
force-pushed
the
SPV_INTEL_joint_matrix
branch
from
3bb8d93 to
e549d01
Compare
Signed-off-by: Alexey Sotkin <alexey.sotkin@intel.com>
AlexeySachkov
approved these changes
Aug 26, 2021
Signed-off-by: Alexey Sotkin <alexey.sotkin@intel.com>
Signed-off-by: Alexey Sotkin <alexey.sotkin@intel.com>
Quetzonarch
pushed a commit
to Quetzonarch/SPIRV-LLVM-Translator
that referenced
this pull request
Aug 27, 2021
The spec is available at intel/llvm#4373 Signed-off-by: Alexey Sotkin <alexey.sotkin@intel.com>
Quetzonarch
pushed a commit
to Quetzonarch/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 13, 2022
The spec is available at intel/llvm#4373 Signed-off-by: Alexey Sotkin <alexey.sotkin@intel.com>
vmaksimo
pushed a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 1, 2022
…sion (KhronosGroup#1165) 'master' -> 'xmain-web' (#4) CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/spirv_internal.hpp CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVType.h CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVType.cpp CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVOpCodeEnumInternal.h CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVOpCode.h CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVModule.h CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVModule.cpp CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVInstruction.h CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVWriter.cpp CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVUtil.cpp CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVRegularizeLLVM.cpp CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVReader.cpp CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVInternal.h CONFLICT (content): Merge conflict in lib/SPIRV/CMakeLists.txt CONFLICT (content): Merge conflict in include/LLVMSPIRVExtensions.inc commit 44f6f57 Author: Alexey Sotkin <alexey.sotkin@intel.com> Date: Fri Aug 27 01:03:49 2021 +0300 Add support for SPV_INTEL_joint_matrix extension (KhronosGroup#1165) The spec is available at intel/llvm#4373 Signed-off-by: Alexey Sotkin <alexey.sotkin@intel.com> Change-Id: I2c5762d4f94578b4c806086eea30592cacf603fe
vmaksimo
pushed a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 1, 2022
extension (KhronosGroup#1165) 'master' -> 'xmain-web' (#4) CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/spirv_internal.hpp CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVType.h CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVType.cpp CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVOpCodeEnumInternal.h CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVOpCode.h CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVModule.h CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVModule.cpp CONFLICT (content): Merge conflict in lib/SPIRV/libSPIRV/SPIRVInstruction.h CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVWriter.cpp CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVUtil.cpp CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVRegularizeLLVM.cpp CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVReader.cpp CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVInternal.h CONFLICT (content): Merge conflict in lib/SPIRV/CMakeLists.txt CONFLICT (content): Merge conflict in include/LLVMSPIRVExtensions.inc commit 44f6f57 Author: Alexey Sotkin <alexey.sotkin@intel.com> Date: Fri Aug 27 01:03:49 2021 +0300 Add support for SPV_INTEL_joint_matrix extension (KhronosGroup#1165) The spec is available at intel/llvm#4373 Signed-off-by: Alexey Sotkin <alexey.sotkin@intel.com> Change-Id: I5c904a6d8b27d98d6850ed291060986095b9b9e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec is available at intel/llvm#4373