Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSL: Image gather ConstOffsets supports multiple address spaces. #2344

Merged

Conversation

billhollings
Copy link
Contributor

Required when using descriptor set argument buffers.

  • Output overloaded functions for each address space.
  • Update test shaders.

spirv_msl.cpp Outdated Show resolved Hide resolved
spirv_msl.cpp Outdated Show resolved Hide resolved
spirv_msl.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@HansKristian-Work HansKristian-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits.

Required when using descriptor set argument buffers.

- Output overloaded functions for each address space.
- Update test shaders.
@billhollings billhollings force-pushed the gather-constoffsts-arg-buffs branch from 30c4de0 to b5ccb0c Compare June 18, 2024 14:55
@HansKristian-Work HansKristian-Work merged commit 5d127b9 into KhronosGroup:main Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants