MSL: Fixes for constexpr sampler use with argument buffers. #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constexpr samplers are defined as local variables, but were treated as held within an argument buffer. - CompilerMSL::to_sampler_expression() support constexpr samplers when using argument buffers, plus refactor to minimize generating expression text that may not be used. - Handle padding around multi-plane images that require multiple textures. Only check for padding on the first plane, but include plane count in total argument buffer slots consumed.
billhollings
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constexpr samplers are defined as local variables, but were treated as held within an argument buffer.
CompilerMSL::to_sampler_expression()support constexpr samplers when using argument buffers, plus refactor to minimize generating expression text that may not be used.Handle padding around multi-plane images that require multiple textures. Only check for padding on the first plane, but include plane count in total argument buffer slots consumed.
I experimented with a unit test, but couldn't figure out how to add the ability to define a constexpr sampler into the API in a straightforward manner.