Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the SPV_QCOM_image_processing extension #2246

Merged

Conversation

wooyoungqcom
Copy link
Contributor

  1. Add support for the SPV_QCOM_image_processing extension
  2. Add four unit tests
  3. Fix minor issues in other unit tests

Please note that

the following test failed with "The flag --preserve-numeric-ids was specified multiple times."

shaders-no-opt/asm/frag/opaque-id-literal-alias.preserve.asm.frag

the following test failed with "The type of Value must match the Result type"

shaders-no-opt/asm/frag/subgroup-arithmetic-cast.nocompat.vk.asm.frag
shaders-msl-no-opt/asm/frag/subgroup-arithmetic-cast.msl21.asm.frag
%18 = OpGroupNonUniformSMin %uint %uint_3 Reduce %16

the following tests failed with "Selection must be structured"

shaders-no-opt/asm/comp/loop-variable-early-read-with-initializer.asm.comp
OpBranchConditional %69 %12 %13

shaders-no-opt/asm/comp/loop-variable-early-read-with-undef.asm.comp
OpBranchConditional %69 %12 %13

the following tests failed with "OpSpecConstantComposite Constituent '7[%7]'s type does not match Result Type '29[%v3uint]'s vector element type."

shaders-no-opt/asm/comp/local-size-id.vk.asm.comp
shaders-hlsl-no-opt/asm/comp/local-size-id.asm.comp
shaders-msl-no-opt/asm/comp/local-size-id.asm.comp
%38 = OpSpecConstantComposite %v3uint %37 %7 %uint_2

shaders-msl-no-opt/asm/comp/local-size-id.asm.comp
shaders-msl-no-opt/asm/frag/subgroup-arithmetic-cast.msl21.asm.frag

@HansKristian-Work
Copy link
Contributor

HansKristian-Work commented Jan 5, 2024

Rolling deps separately in #2254. You can rebase against that when it lands.
EDIT: Done

@wooyoungqcom wooyoungqcom force-pushed the SPV_QCOM_image_processing branch from 1d7f239 to cffc08a Compare January 6, 2024 06:41
@wooyoungqcom wooyoungqcom reopened this Jan 6, 2024
@wooyoungqcom
Copy link
Contributor Author

Rebased the branch.

spirv_glsl.cpp Outdated Show resolved Hide resolved
spirv_glsl.cpp Outdated Show resolved Hide resolved
spirv_glsl.cpp Outdated Show resolved Hide resolved
spirv_glsl.cpp Outdated Show resolved Hide resolved
spirv_glsl.cpp Outdated Show resolved Hide resolved
spirv_glsl.cpp Outdated Show resolved Hide resolved
@wooyoungqcom
Copy link
Contributor Author

I have made the changes requested.

@HansKristian-Work HansKristian-Work merged commit 37a58e4 into KhronosGroup:main Jan 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants