MSL: Implement MSL 3.1 image atomics natively #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKristian-Work
force-pushed
the
fix-2212
branch
2 times, most recently
from
8aae9c1 to
f8d5a1f
Compare
The check_discard code was too annoying to deal with, and there is no requirement to return anything meaningful. Vulkan specs state that values returned by atomic instructions are undefined.
HansKristian-Work
force-pushed
the
fix-2212
branch
from
f8d5a1f to
a326b3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current CI does not have Metal 3.1 support, but I added support for testing against the Windows tooling, and it passes with that.
Fix #2212.