MSL: centroid/sample barycentrics aren't supported after all.

KhronosGroup · Nov 13, 2024 · 5b93397 · 5b93397
1 parent f669d0c
commit 5b93397
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 228 deletions.
diff --git a/reference/shaders-msl-no-opt/asm/frag/barycentric-centroid-noperspective.msl22.asm.frag b/reference/shaders-msl-no-opt/asm/frag/barycentric-centroid-noperspective.msl22.asm.frag
diff --git a/reference/shaders-msl-no-opt/asm/frag/barycentric-centroid-perspective.msl22.asm.frag b/reference/shaders-msl-no-opt/asm/frag/barycentric-centroid-perspective.msl22.asm.frag
diff --git a/reference/shaders-msl-no-opt/asm/frag/barycentric-sample-noperspective.msl22.asm.frag b/reference/shaders-msl-no-opt/asm/frag/barycentric-sample-noperspective.msl22.asm.frag
diff --git a/reference/shaders-msl-no-opt/asm/frag/barycentric-sample-perspective.msl22.asm.frag b/reference/shaders-msl-no-opt/asm/frag/barycentric-sample-perspective.msl22.asm.frag
diff --git a/shaders-msl-no-opt/asm/frag/barycentric-centroid-noperspective.msl22.asm.frag b/shaders-msl-no-opt/asm/frag/barycentric-centroid-noperspective.msl22.asm.frag
diff --git a/shaders-msl-no-opt/asm/frag/barycentric-centroid-perspective.msl22.asm.frag b/shaders-msl-no-opt/asm/frag/barycentric-centroid-perspective.msl22.asm.frag
diff --git a/shaders-msl-no-opt/asm/frag/barycentric-sample-noperspective.msl22.asm.frag b/shaders-msl-no-opt/asm/frag/barycentric-sample-noperspective.msl22.asm.frag
diff --git a/shaders-msl-no-opt/asm/frag/barycentric-sample-perspective.msl22.asm.frag b/shaders-msl-no-opt/asm/frag/barycentric-sample-perspective.msl22.asm.frag
diff --git a/spirv_msl.cpp b/spirv_msl.cpp
@@ -13063,7 +13063,11 @@ string CompilerMSL::member_attribute_qualifier(const SPIRType &type, uint32_t in
 			{
 				if (!quals.empty())
 					quals += ", ";
-				if (has_member_decoration(type.self, index, DecorationNoPerspective) || builtin == BuiltInBaryCoordNoPerspKHR)
+
+				if (builtin == BuiltInBaryCoordNoPerspKHR || builtin == BuiltInBaryCoordKHR)
+					SPIRV_CROSS_THROW("Centroid interpolation not supported for barycentrics in MSL.");
+
+				if (has_member_decoration(type.self, index, DecorationNoPerspective))
 					quals += "centroid_no_perspective";
 				else
 					quals += "centroid_perspective";
@@ -13072,7 +13076,11 @@ string CompilerMSL::member_attribute_qualifier(const SPIRType &type, uint32_t in
 			{
 				if (!quals.empty())
 					quals += ", ";
-				if (has_member_decoration(type.self, index, DecorationNoPerspective) || builtin == BuiltInBaryCoordNoPerspKHR)
+
+				if (builtin == BuiltInBaryCoordNoPerspKHR || builtin == BuiltInBaryCoordKHR)
+					SPIRV_CROSS_THROW("Sample interpolation not supported for barycentrics in MSL.");
+
+				if (has_member_decoration(type.self, index, DecorationNoPerspective))
 					quals += "sample_no_perspective";
 				else
 					quals += "sample_perspective";