Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated AsyncRequestIdFB does not compile due to undeclared XR_NULL_ASYNC_REQUEST_ID_FB #34

Closed
KiruyaMomochi opened this issue Nov 24, 2022 · 5 comments

Comments

@KiruyaMomochi
Copy link
Contributor

Current generated headers does not compile. The generated AsyncRequestIdFB struct in openxr_atoms.hpp uses XR_NULL_ASYNC_REQUEST_ID_FB, but this macro is actually not declared in openxr.h.

A quick workaround maybe add a global variable NO_NULL_ATOMS in cpp_generator.py and return 0 for such atoms in computeNullAtom.

@rpavlik
Copy link
Contributor

rpavlik commented Nov 29, 2022

hmm, where is it generated?

@KiruyaMomochi
Copy link
Contributor Author

KiruyaMomochi commented Dec 7, 2022

Sorry for late reply. My "current" means generating C++ projection for the latest (1.0.26) OpenXR SDK source.

The generated AsyncRequestIdFB struct is in file openxr_atoms.hpp.

https://gist.github.com/KiruyaMomochi/71688ea5246ab38a98755d508daae4fe#file-openxr_atoms-hpp-L774-L778

@rpavlik
Copy link
Contributor

rpavlik commented Dec 7, 2022

Hmm, I suspect that instead, we should have such atoms not have a default constructor and those methods that depend on having such a define. 0 is not inherently invalid for this atom, it appears.

@rpavlik
Copy link
Contributor

rpavlik commented Dec 7, 2022

Raised an issue on the extension itself because suppressing this is harder than I anticipated.

rpavlik added a commit to KiruyaMomochi/OpenXR-Hpp that referenced this issue Dec 7, 2022
@rpavlik
Copy link
Contributor

rpavlik commented Dec 8, 2022

Compilation fixed in #35 , re-enabled type in #37

@rpavlik rpavlik closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants