for now, remove aliases to cl_mem_migration_flags #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of adding aliases to cl_mem_migration_flags and associated enums, restrict the clEnqueueMigrateMemINTEL API to OpenCL 1.2 or newer, which satisfies all current use-cases. If needed, the aliases can be re-introduced at a later date, since adding them does not change the ABI.
alycm
approved these changes
Jun 8, 2020
Contributor
alycm
left a comment
alycm
left a comment
There was a problem hiding this comment.
LGTM, sorry that this has been sat so long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding aliases to
cl_mem_migration_flagsand associated enums, restrict theclEnqueueMigrateMemINTELAPI to OpenCL 1.2 or newer, which satisfies all current use-cases.If needed, the aliases can be re-introduced at a later date, since adding them does not change the ABI.
See related header file PR: KhronosGroup/OpenCL-Headers#65