-
Notifications
You must be signed in to change notification settings - Fork 124
Updates cl.xml for the cl_intel_unified_shared_memory extension #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates cl.xml for the cl_intel_unified_shared_memory extension #192
Conversation
|
Hello, In this PR you wrote the |
|
@oddhack, can you provide advice when the |
We use it consistently in the Vulkan and XR XML now. It is not necessary for C header generation and our other internal uses, though, because there's no actual dependency to satisfy to define the type before use. That is the purpose of the <type> tag. So I'd say it's your call to use it or not, but best to be consistent so the question doesn't keep coming up. |
Enum values 0x417E and 0x417F are used, so only the range 0x4170-9x417D are unused.
|
@bashbaug You're welcome. I deleted the comment because I have a whole list of them and it will really be out of the scope of the pull request. |
alycm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Just FYI, I have the type markup changes done to address #196, but they build upon this change, so I'd like to merge this first. |
These changes are consistent with the PR for the OpenCL headers, see: KhronosGroup/OpenCL-Headers#65
The extension spec is a touch out-of-date on github, but can be found here. I will be updating it to the revision described by these changes (or newer) shortly.
I have scripts that use the API definitions so I am reasonably confident that they are correct. I'm less confident regarding the typedefs and enum changes, but I have verified that the OpenCL specs still build correctly with these changes.