Add Vulkan 1.3 command stubs #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spnda
force-pushed
the
provide_1_3_stubs
branch
from
237aa53 to
8f03dbf
Compare
billhollings
requested changes
Sep 24, 2022
spnda
force-pushed
the
provide_1_3_stubs
branch
2 times, most recently
from
7c51922 to
754837a
Compare
|
If you update from master, it should fix the breaking CI build for Xcode 11.7. PR #1724 included a fix for that. [edit]: NM...looks like there are other breakages as well. 😉 |
spnda
force-pushed
the
provide_1_3_stubs
branch
from
754837a to
454072d
Compare
spnda
force-pushed
the
provide_1_3_stubs
branch
from
454072d to
6eaa035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1708.
Just like the Vulkan lib that comes with the SDK, MoltenVK should expose stubs of Vulkan core functions to use while statically linking MoltenVK directly. Some libraries and applications expect these symbols to be available, though will still conditionally use them based on the physical device's properties. Using these functions in an application would be UB as the device reports Vulkan 1.1, so there's really nothing lost here.