Simplify grammar for identifier_list #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An identifier list was defined as one or more identifiers preceded by a comma, so an additional rule was needed for a single identifier. Change the identifier_list to be what would normally be expected, a comma-separated list of one or more identifiers, and remove the additional rule.
|
@dj2 this was my first grammar change that was not taken up. The grammar is full of things like this that I consider to be bizarre and unhelpful definitions of commonplace things. |
dj2
approved these changes
Sep 11, 2024
|
Update to glslang to use the simpler grammar here: KhronosGroup/glslang#3772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An identifier list was defined as one or more identifiers preceded by a comma, so an additional rule was needed for a single identifier. Change the identifier_list to be what would normally be expected, a comma-separated list of one or more identifiers, and remove the additional rule.