Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

avoids emitting duplicate import declarations in case of multiple type imports #283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

demedos
Copy link

@demedos demedos commented May 18, 2021

avoids emitting duplicate import declarations in case of multiple type imports

fixes #281

@kevinbarabash
Copy link
Contributor

Hey @demedos,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Once you've done that, could you also add a test case that verifies the change you've made?

@kevinbarabash kevinbarabash self-requested a review May 18, 2021 14:49
@aminya
Copy link
Contributor

aminya commented Jun 25, 2021

@kevinbarabash could you take a look at this? When someone contributes to a project, that implies that they comply with the license. There is no reason to collect separate signatures for that.

@demedos
Copy link
Author

demedos commented Jun 29, 2021

@kevinbarabash could you take a look at this? When someone contributes to a project, that implies that they comply with the license. There is no reason to collect separate signatures for that.

Thank you, that is the exact reason I didn't update the pull request.

@kevinbarabash
Copy link
Contributor

Thanks for the feedback and for the contribution. Unfortunately, the implication of agreement is not sufficient for us and we need all contributors to sign the agreement so that it is explicit that the license agreement has been read and understood. We try to make the CLA process as smooth as possible but do need a CLA signed (as do many other open source initiatives). Thank you for taking a moment to do so.

@aminya
Copy link
Contributor

aminya commented Jul 15, 2021

@demedos Are you interested in signing the CLA? If not, I can do this because I have already made PRs to this repository.

@demedos
Copy link
Author

demedos commented Jul 26, 2021

@demedos Are you interested in signing the CLA? If not, I can do this because I have already made PRs to this repository.

Feel free to do so

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple type import duplicates the import statement
3 participants