-
Notifications
You must be signed in to change notification settings - Fork 1
Add major version tags, to allow implicit upgrades for patch & minor versions #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
49674d5
Readme, package.json, changesets, and README
jaredly 8d8993d
Bring over our composite actions from Khan/perseus
jaredly 2ecc423
Add scripts to build & publish our github actions, to 'bare tags' in …
jaredly 2e88c2a
cs
jaredly 90912bc
cs
jaredly 9872ee4
move to utils
jaredly 83543dd
Add eslint & prettier
jaredly 569baa0
action
jaredly ba2bf81
separate run
jaredly b39f5e0
refactor out the tricky bit
jaredly feb1417
Merge branch 'publish' into lints
jaredly 753d6f7
fix
jaredly b36e072
lint
jaredly 45ad3b3
Merge branch 'main' into publish
jaredly a4eee22
fix
jaredly 3b4a112
ok
jaredly bcd4999
Merge branch 'main' into lints
jaredly 6497194
cs
jaredly 1538ebf
Add major version tags, to allow implicit upgrades for patch & minor …
jaredly 8e90c0e
cs
jaredly 198c7eb
lint
jaredly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /** | ||
| * This is a very stripped-down eslintrc, because @khanacademy/eslint-config | ||
| * assumes you're using react & flow (and requires a lot of dependencies along | ||
| * with it). | ||
| */ | ||
| const khan = require("@khanacademy/eslint-config"); | ||
|
|
||
| // Only keep the rules that have no prefix (so are included in eslint core) | ||
| // and the prettier rule. | ||
| const basicRules = {}; | ||
| Object.keys(khan.rules).forEach((key) => { | ||
| if (!key.includes("/") || key.startsWith("prettier/")) { | ||
| basicRules[key] = khan.rules[key]; | ||
| } | ||
| }); | ||
|
|
||
| module.exports = { | ||
| extends: ["eslint:recommended", "prettier"], | ||
| plugins: ["prettier"], | ||
| rules: basicRules, | ||
| env: { | ||
| node: true, | ||
| }, | ||
| parserOptions: { | ||
| sourceType: "module", | ||
| ecmaVersion: 2022, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| module.exports = require("@khanacademy/eslint-config/.prettierrc.js"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this overwrite the major tag with whatever the most updated to minor.patch version within that major version is? Nice solution.