Conversation
Summary: Setting up this repository! Very excited. Test plan: 🚫
Summary: They'd been copied over from graphql-flow, but I figured the Khan/perseus ones might have more recent changes. The next PR will contain our build & publish scripts. I also created a 'check-for-changeset' action that I noticed in the perseus pr-actions workflow :) Test plan: 🤞 not usable/testable quite yet!
…the Khan/actions repo Summary: Here's the magic! This will allow us to reference e.g. `Khan/actions@filter-files-v0.0.1` in our workflows (as described in the readme). I've also added basic workflows, one to check for a changeset, and one to automate releases when a release PR lands. Test plan: See the workflow work! I published check-for-changeset-v0.0.0 manually from the CLI to demonstrate.
Summary: It's very simple for the moment because we're not doing any transpilation. We might decide to adopt typescript or something if we start to have more complicated actions. Test plan: `yarn lint` should work! Also see the github action doing its thing.
k4b7
approved these changes
May 19, 2022
Comment on lines
+8
to
+9
| // Only keep the rules that have no prefix (so are included in eslint core) | ||
| // and the prettier rule. |
Contributor
There was a problem hiding this comment.
I had a look at khan/eslint-config-khan and see that everything's listed as a peer dep. I wonder if we should change that.
| "actions/*" | ||
| ], | ||
| "scripts": { | ||
| "lint": "eslint --ext .js,.mjs .", |
Contributor
There was a problem hiding this comment.
I didn't realize you pass a comma separated list to --ext, cool!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
It's very simple for the moment because we're not doing any transpilation. We might decide to adopt typescript or something if we start to have more complicated actions.
Issue: XXX-XXXX
Test plan:
yarn lintshould work!Also see the github action doing its thing.