Repository navigation
review: stop recommending gh aw update in the consumer README #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
96c2fbc
[jwbron/review-readme-manual-merge] review: stop recommending gh aw u…
jwbron 9c901e3
[jwbron/review-readme-manual-merge] review: ban gh aw update everywhe…
jwbron b1ec70d
Merge remote-tracking branch 'origin/main' into HEAD
jwbron 5c6893e
review: sweep the last runtime gh aw update mention; give the update …
jwbron 7d260c3
Merge remote-tracking branch 'origin/main' into HEAD
jwbron 6954124
Merge remote-tracking branch 'origin/main' into HEAD
jwbron bb9af89
review: rewrite the changeset for the post-#357 diff; make the stop l…
jwbron 1410e5b
Merge remote-tracking branch 'origin/main' into HEAD
jwbron ccfbda9
review: soften the stop-comment claim, put the revisit condition in t…
jwbron fa9ee8f
review: the ban sweep scans every tracked file and spares the CHANGELOG
jwbron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "review": patch | ||
| --- | ||
|
|
||
| Docs only: stop recommending `gh aw update` anywhere in this repo. The review-consumer-bump skill (Khan/actions#357) documents it failing twice against this repo's tag scheme, observed live on 2026-08-20: it treats `review-v<version>` as a branch and repins to main's head SHA, and its 3-way merge emptied a consumer's installed `review.md` to 0 bytes (gh-aw v0.85.4). The consumer-facing README recommended it in 4 places and the review-onboarding skill in another 4; all 8 now describe the maintainer-driven bump flow (a manual `git merge-file` 3-way merge, one PR per consumer) and the README names the failure modes plus the condition for revisiting the ban (neither failure is filed upstream yet). The shipped `review.md` changes only in a frontmatter comment (the observability local-edit note no longer names `gh aw update` as the merger); no behavior change. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.