Skip to content

[🔥AUDIT🔥] review: fix the clusterer example that promises cross-file grouping the path rule forbids #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwbron merged 1 commit into from
Aug 11, 2026
Merged

[🔥AUDIT🔥] review: fix the clusterer example that promises cross-file grouping the path rule forbids #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/review-clusterer-example-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"review": patch
---

The claim-clusterer prompt's cross-anchor example no longer promises a grouping its own path rule forbids: "its test" (a separate `_test.go`, so a different `path`) is replaced by a same-file anchor, and the cross-file limit is stated explicitly beside the example. Found by the reviewer itself on the webapp v1.12.0 bump PR.
7 changes: 5 additions & 2 deletions workflows/review/review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,8 +1550,11 @@ proximity:
wrong, even when one calls it a wrong cap, one quotes the comment, and one cites a
doc-comment convention: one rewritten comment satisfies all three.
- **Group** across lines. A defect is routinely flagged at different anchors (the
function, its doc comment, its test), and the pipeline keeps one anchor. Distance in
the file is not evidence of two defects.
function, its doc comment, the call site below it), and the pipeline keeps one anchor.
Distance in the file is not evidence of two defects. (A twin anchored in another FILE
— e.g. the test in `_test.go` — stays ungrouped under the same-`path` rule below,
however clearly it describes the same defect; the pipeline prices that as a duplicate
comment, not a wrong merge.)
- **Do NOT group** a bug and the missing test for that bug. "The cutoff subtracts months
instead of days" and "no test asserts a stale entry is deleted" cite the same facts and
need two different edits; they are two defects.
Expand Down
Loading