Conversation
Summary: Setting up this repository! Very excited. Test plan: 🚫
Summary: They'd been copied over from graphql-flow, but I figured the Khan/perseus ones might have more recent changes. The next PR will contain our build & publish scripts. I also created a 'check-for-changeset' action that I noticed in the perseus pr-actions workflow :) Test plan: 🤞 not usable/testable quite yet!
jeresig
approved these changes
May 19, 2022
| id: result | ||
| with: | ||
| script: | | ||
| const extensionsRaw = "${{ inputs.extensions }}"; |
Member
There was a problem hiding this comment.
I wonder if we should have a policy (in a future change) of breaking out inline scripts to be imported from another file? That way we can lint and test them, for example: https://github.com/actions/github-script#run-a-separate-file
Contributor
Author
There was a problem hiding this comment.
on interesting, I didn't know that was an option! Sounds like a good policy.
Contributor
There was a problem hiding this comment.
@jeresig has that always been possible or is this a new feature? Either way, I'm glad it's possible.
Member
There was a problem hiding this comment.
Always been possible, I believe!
k4b7
reviewed
May 19, 2022
| @@ -0,0 +1,28 @@ | |||
| name: Full or Limited | |||
Contributor
There was a problem hiding this comment.
Thanks for abstracting this into an action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
They'd been copied over from graphql-flow, but I figured the Khan/perseus ones might have more recent changes.
The next PR will contain our build & publish scripts.
I also created a 'check-for-changeset' action that I noticed in the perseus pr-actions workflow :)
Issue: https://khanacademy.atlassian.net/browse/FEI-4550
Test plan:
🤞 not usable/testable quite yet!