Skip to content

review: always submit REQUEST_CHANGES with a non-empty body #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwbron merged 2 commits into from
Jul 14, 2026
Merged

review: always submit REQUEST_CHANGES with a non-empty body #262

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfb559f
[jwies/review-rc-body] review: always submit REQUEST_CHANGES with a n…
jwbron Jul 14, 2026
4dd59a0
[jwies/review-rc-body] review: scope the empty-body convention to APP…
jwbron Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/review-rc-body.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"review": patch
---

Always submit REQUEST_CHANGES with a non-empty body. Step 6 previously instructed the opposite ("a REQUEST_CHANGES verdict carries at least one blocking inline comment, so submit it with an empty body", dating to #197): GitHub rejects a REQUEST_CHANGES review event with an empty body, and under gh-aw v0.81.6 the safe-output flow posts the review event separately from the inline comments, so the comments do not make it non-empty. Observed live on the v1.5.0 behavior test (Khan/webapp#40793): the reviewer computed REQUEST_CHANGES correctly for two blocking findings, the submission failed with "Review body is required for REQUEST_CHANGES", and the PR was left with the inline comments as a COMMENTED review and no blocking verdict. The latent instruction survived this long because models usually filled the body anyway. The body's first line is now always `Changes requested — see inline comments.`, with the accountability section, note lines, and fingerprint stamp appended as before.
10 changes: 6 additions & 4 deletions workflows/review/review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1251,13 +1251,15 @@ submittable, or to carry a skipped-dimension note (below).
- **If you left no inline comments**, submit the APPROVE event with the body set to
exactly `Approved — no blocking issues found.` and nothing else.

**If REQUEST_CHANGES:** a REQUEST_CHANGES verdict carries at least one blocking
inline comment (the verdict follows from the comments you posted), so submit it with
an **empty** body. Only if no inline comment was posted (which should not happen),
keep the body to a single line:
**If REQUEST_CHANGES:** always submit the event with a non-empty body whose first
Comment thread
khan-actions-bot marked this conversation as resolved.
line is exactly:
```
Changes requested — see inline comments.
```
GitHub REJECTS a REQUEST_CHANGES review event with an empty body (the safe-output
Comment thread
khan-actions-bot marked this conversation as resolved.
submission posts the event separately from the inline comments, so the comments do
not make it non-empty); an empty body here loses the blocking verdict entirely
while the inline comments post as a mere COMMENTED review.

**Re-review accountability (either verdict; code-rendered).** When
`threads.json` (Step 3 Phase 2) staged at least one unresolved bot thread this run,
Expand Down
Loading