Conversation
Summary: Setting up this repository! Very excited. Test plan: 🚫
jaredly
changed the title
jeresig
approved these changes
May 19, 2022
jeresig
left a comment
jeresig
left a comment
Member
There was a problem hiding this comment.
This looks great! That gitpkg looks extremely cool and exactly what we want!
Could you add Gerald in to and make the github-actions team the default reviewer of all changes to this repo?
k4b7
approved these changes
May 19, 2022
|
|
||
| ## How does the monorepo work? | ||
|
|
||
| Github doesn't support putting actions in subdirectories, so we need to do some fancy work here. Inspired by [gitpkg](https://github.com/ramasilveyra/gitpkg), we "publish" versions of our actions to 'bare tags' in this repo. So the tag `filter-files-v0.0.1` would only contain the files for the `filter-files` action, and thus github is perfectly happy for us to reference it as `uses: @Khan/actions#filter-files-v0.0.1`. |
Contributor
There was a problem hiding this comment.
Sneaky. This should also allow us to not have to check in the build files on main.
|
|
||
| Github doesn't support putting actions in subdirectories, so we need to do some fancy work here. Inspired by [gitpkg](https://github.com/ramasilveyra/gitpkg), we "publish" versions of our actions to 'bare tags' in this repo. So the tag `filter-files-v0.0.1` would only contain the files for the `filter-files` action, and thus github is perfectly happy for us to reference it as `uses: @Khan/actions#filter-files-v0.0.1`. | ||
|
|
||
| Actions that depend on other actions within this repo (with e.g. `uses: filter-files`) will have the references automatically converted to the appropriated pinned reference (e.g. `Khan/actions#filter-files-v0.0.1`) as part of the publish process. |
Contributor
There was a problem hiding this comment.
That's pretty sneaky. What's responsible for updating these references?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Setting up this repository! Very excited.
Issue: part of https://khanacademy.atlassian.net/browse/FEI-4550
Test plan:
🚫