Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 182 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions remote-wallet/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ solana-signature = { workspace = true, features = ["std"] }
solana-signer = { workspace = true }
thiserror = { workspace = true }
uriparse = { workspace = true }
serde_json = { workspace = true }
hex = { workspace = true }
ur-registry = { git = "https://github.com/KeystoneHQ/keystone-sdk-rust.git", tag = "0.0.50", default-features = false, features = ["std"] }
ur-parse-lib = { git = "https://github.com/KeystoneHQ/keystone-sdk-rust.git", tag = "0.0.50" }

[dev-dependencies]
assert_matches = { workspace = true }
Expand Down
5 changes: 5 additions & 0 deletions remote-wallet/src/errors.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use crate::locator::LocatorError;
use crate::wallet::keystone::error::KeystoneError;
use crate::wallet::ledger::error::LedgerError;
use solana_derivation_path::DerivationPathError;
use solana_signer::SignerError;
Expand Down Expand Up @@ -28,6 +29,9 @@ pub enum RemoteWalletError {
#[error(transparent)]
LedgerError(#[from] LedgerError),

#[error(transparent)]
KeystoneError(#[from] KeystoneError),

#[error("no device found")]
NoDeviceFound,

Expand Down Expand Up @@ -59,6 +63,7 @@ impl From<RemoteWalletError> for SignerError {
RemoteWalletError::InvalidDevice => SignerError::Connection(err.to_string()),
RemoteWalletError::InvalidInput(input) => SignerError::InvalidInput(input),
RemoteWalletError::LedgerError(e) => SignerError::Protocol(e.to_string()),
RemoteWalletError::KeystoneError(e) => SignerError::Protocol(e.to_string()),
RemoteWalletError::NoDeviceFound => SignerError::NoDeviceFound,
RemoteWalletError::Protocol(e) => SignerError::Protocol(e.to_string()),
RemoteWalletError::UserCancel => {
Expand Down
4 changes: 4 additions & 0 deletions remote-wallet/src/locator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ use {
pub enum Manufacturer {
Unknown,
Ledger,
Keystone,
}

impl Default for Manufacturer {
Expand All @@ -22,6 +23,7 @@ impl Default for Manufacturer {

const MANUFACTURER_UNKNOWN: &str = "unknown";
const MANUFACTURER_LEDGER: &str = "ledger";
const MANUFACTURER_KEYSTONE: &str = "keystone";

#[derive(Clone, Debug, Error, PartialEq, Eq)]
#[error("not a manufacturer")]
Expand All @@ -39,6 +41,7 @@ impl FromStr for Manufacturer {
let s = s.to_ascii_lowercase();
match s.as_str() {
MANUFACTURER_LEDGER => Ok(Self::Ledger),
MANUFACTURER_KEYSTONE => Ok(Self::Keystone),
_ => Err(ManufacturerError),
}
}
Expand All @@ -56,6 +59,7 @@ impl AsRef<str> for Manufacturer {
match self {
Self::Unknown => MANUFACTURER_UNKNOWN,
Self::Ledger => MANUFACTURER_LEDGER,
Self::Keystone => MANUFACTURER_KEYSTONE,
}
}
}
Expand Down
20 changes: 19 additions & 1 deletion remote-wallet/src/remote_keypair.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ use {
errors::RemoteWalletError,
locator::{Locator, Manufacturer},
remote_wallet::{RemoteWallet, RemoteWalletInfo, RemoteWalletManager},
wallet::{ledger::ledger::get_ledger_from_info, types::RemoteWalletType},
wallet::{
keystone::keystone::get_keystone_from_info, ledger::ledger::get_ledger_from_info,
types::RemoteWalletType,
},
},
solana_derivation_path::DerivationPath,
solana_pubkey::Pubkey,
Expand All @@ -27,6 +30,9 @@ impl RemoteKeypair {
) -> Result<Self, RemoteWalletError> {
let pubkey = match &wallet_type {
RemoteWalletType::Ledger(wallet) => wallet.get_pubkey(&derivation_path, confirm_key)?,
RemoteWalletType::Keystone(wallet) => {
wallet.get_pubkey(&derivation_path, confirm_key)?
}
};

Ok(Self {
Expand All @@ -48,6 +54,9 @@ impl Signer for RemoteKeypair {
RemoteWalletType::Ledger(wallet) => wallet
.sign_message(&self.derivation_path, message)
.map_err(|e| e.into()),
RemoteWalletType::Keystone(wallet) => wallet
.sign_message(&self.derivation_path, message)
.map_err(|e| e.into()),
}
}

Expand All @@ -73,6 +82,15 @@ pub fn generate_remote_keypair(
confirm_key,
path,
)?)
} else if remote_wallet_info.manufacturer == Manufacturer::Keystone {
let keystone = get_keystone_from_info(remote_wallet_info, keypair_name, wallet_manager)?;
let path = format!("{}{}", keystone.pretty_path, derivation_path.get_query());
Ok(RemoteKeypair::new(
RemoteWalletType::Keystone(keystone),
derivation_path,
confirm_key,
path,
)?)
} else {
Err(RemoteWalletError::DeviceTypeMismatch)
}
Expand Down
Loading