Retreive role name (product ID) from metadata if available #7
Conversation
joevanwanzeeleKF
commented
Sep 9, 2025
joevanwanzeeleKF
commented
- Certificates generated outside of Command that have have certificate metadata (including role name) can now be managed via Keyfactor Command.
There was a problem hiding this comment.
Pull Request Overview
This PR enables certificates generated outside of Keyfactor Command to be managed within Command by retrieving role names from certificate metadata when available. The main functionality allows the system to extract the role name (product ID) from Hashicorp Vault Enterprise certificate metadata during synchronization.
- Added metadata retrieval functionality to extract role names from certificates issued outside Command
- Removed validation requirement for role names in product configuration since they can now be retrieved from metadata
- Updated copyright notices to 2025 and disabled client certificate authentication temporarily
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| readme_source.md | Added documentation explaining metadata requirements for external certificates |
| HashicorpVaultCAConnector.cs | Implemented metadata retrieval logic and removed role name validation |
| HashicorpVaultClient.cs | Added GetCertMetadata method to fetch certificate metadata |
| APIProxy/MetadataResponse.cs | New class defining metadata response structure |
| integration-manifest.json | Added release_project configuration |
| Multiple files | Updated copyright year to 2025 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| catch (Exception) | ||
| { | ||
| logger.LogTrace("an error occurred when attempting to retreive the metadata, continuing.."); |
There was a problem hiding this comment.
The word 'retreive' is misspelled. It should be 'retrieve'.
| } | ||
| catch (Exception ex) | ||
| { | ||
| logger.LogError($"an error occurred when attempting to retreive the certificate metadata: {ex.Message}"); |
There was a problem hiding this comment.
The word 'retreive' is misspelled. It should be 'retrieve'.
This reverts commit 33d52cc.
