added logging for troubleshooting #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds debugging capabilities by introducing additional logging statements and updating a dependency to the latest version.
- Added trace-level logging for troubleshooting entry parameters in the Management job
- Updated IOrchestratorJobExtensions package from version 0.7.0 to 1.0.0
- Reorganized README documentation structure with improved formatting and additional PAM integration details
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Restructured documentation with improved formatting, moved AKV description, added PAM integration section, and fixed spelling errors |
| AzureKeyVault/Jobs/Management.cs | Added trace logging for job properties and refactored entry parameter parsing with improved error handling |
| AzureKeyVault/AzureKeyVault.csproj | Updated IOrchestratorJobExtensions dependency to version 1.0.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| using Keyfactor.Orchestrators.Extensions.Interfaces; | ||
| using System.Collections.Generic; | ||
| using Newtonsoft.Json; | ||
| using System.Security.AccessControl; |
There was a problem hiding this comment.
The System.Security.AccessControl import is unused in this file. Consider removing it to keep imports clean.
Suggested change
| using System.Security.AccessControl; |
Copilot uses AI. Check for mistakes.
| The Azure Key Vault Universal Orchestrator extension If you have a support issue, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. | ||
| > To report a problem or suggest a new feature, use the **[Issues](../../issues)** tab. If you want to contribute actual bug fixes or proposed enhancements, use the **[Pull requests](../../pulls)** tab. | ||
| The Azure Key Vault Universal Orchestrator extension is supported by Keyfactor. If you require support for any issues or have feature request, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. |
There was a problem hiding this comment.
Missing article 'a' before 'feature request'.
Suggested change
| The Azure Key Vault Universal Orchestrator extension is supported by Keyfactor. If you require support for any issues or have feature request, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. | |
| The Azure Key Vault Universal Orchestrator extension is supported by Keyfactor. If you require support for any issues or have a feature request, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com. |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.