Update NPM ignore to reduce bundle size #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using both a .gitignore and .npmignore, npm will favor the .npmignore and will not reference the .gitignore. This commit copies over missing entries from the .gitignore into the .npmignore. Current bundle contains ~7MB in coverage/ - this was already in the .npmignore though. I'm not sure what the release process looks like, but it may require further investigation by the maintainers to fully resolve.
|
This is a small change I hope it gets merged because it will reduce the bundle size by 85%! |
|
@dogabudak any chance you could take a look at this? |
|
would be nice to also ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using both a .gitignore and .npmignore, npm will favor the .npmignore
and will not reference the .gitignore. This commit copies over missing
entries from the .gitignore into the .npmignore.
Current bundle contains ~7MB in coverage/ - this was already
in the .npmignore though. I'm not sure what the release process looks
like, but it may require further investigation by the maintainers to
fully resolve #417, #387, and #393.