Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/docs #175

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Fix/docs #175

merged 7 commits into from
Oct 19, 2023

Conversation

alessandrojcm
Copy link
Collaborator

@alessandrojcm alessandrojcm commented Oct 19, 2023

Got docs to compile again. Although they work, they (obviously) still need updating. Also, two things:

  • Changes to the code highlighting made some parts of the docs look odd, the line break between text and the code block doesn't look good IMO. For this I think we should use InlineCodeHighlight
  • There is a weird pre-rendering error with SourceCodeSnippet, the Select for the theme shade uses the default shade from the useMantineTheme hook which is for some reason not present a build time. I have added a ?? operator and hardcoded the shade so it works; not ideal but it works.

@vercel
Copy link

vercel bot commented Oct 19, 2023

@alessandrojcm is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@KevinVandy KevinVandy merged commit cf9f538 into KevinVandy:v2 Oct 19, 2023
1 check failed
@alessandrojcm alessandrojcm deleted the fix/docs branch October 27, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants