Fix kwargs not passed to SubCenterArcFaceLoss

src/pytorch_metric_learning/losses/subcenter_arcface_loss.py

@@ -1,4 +1,5 @@
 import math
+from copy import deepcopy
 
 import numpy as np
 import torch
@@ -13,9 +14,12 @@ class SubCenterArcFaceLoss(ArcFaceLoss):
     """
 
     def __init__(self, *args, margin=28.6, scale=64, sub_centers=3, **kwargs):
-        num_classes, embedding_size = kwargs["num_classes"], kwargs["embedding_size"]
+        num_classes = deepcopy(kwargs["num_classes"])
+        embedding_size = deepcopy(kwargs["embedding_size"])
+        del kwargs["num_classes"]
+        del kwargs["embedding_size"]
         super().__init__(
-            num_classes * sub_centers, embedding_size, margin=margin, scale=scale
+            num_classes=num_classes * sub_centers, embedding_size=embedding_size, margin=margin, scale=scale, **kwargs
         )
         self.sub_centers = sub_centers
         self.num_classes = num_classes

tests/losses/test_subcenter_arcface_loss.py

@@ -6,6 +6,7 @@
 import torch.nn.functional as F
 
 from pytorch_metric_learning.losses import ArcFaceLoss, SubCenterArcFaceLoss
+from pytorch_metric_learning.reducers import DoNothingReducer
 
 from .. import TEST_DEVICE, TEST_DTYPES
 
@@ -142,3 +143,19 @@ def test_inference_subcenter_arcface(self):
                     )
                     == 0
                 )
+
+    def test_reducer_subcenter_arcface(self):
+
+        arcfaceloss = SubCenterArcFaceLoss(
+            num_classes=10,
+            sub_centers=3,
+            embedding_size=64,
+            reducer=DoNothingReducer(),
+        )
+
+        emb = torch.randn(4, 64)
+        result = arcfaceloss(emb, torch.arange(4))
+
+        self.assertTrue(isinstance(result, dict))
+        self.assertTrue(result['loss']['losses'].shape[0] == 4)
+