Skip to content

fix test_histogram_loss#668

Merged
KevinMusgrave merged 20 commits intoKevinMusgrave:devfrom
GaetanLepage:master
Oct 18, 2023
Merged

fix test_histogram_loss#668
KevinMusgrave merged 20 commits intoKevinMusgrave:devfrom
GaetanLepage:master

Conversation

@GaetanLepage
Copy link
Copy Markdown
Contributor

With pytorch 2.1.0, the following test fail:

tests/losses/test_histogram_loss.py::TestHistogramLoss::test_histogram_loss

Log:

         if self.cuda:
             histogram_pos_inds = histogram_pos_inds.cuda()
>       histogram_pos_repeat[histogram_pos_inds] = 0
E       RuntimeError: masked_fill_ only supports boolean masks, but got mask with dtype unsigned char

tests/losses/test_histogram_loss.py:112: RuntimeError

This patch should address it.

@KevinMusgrave KevinMusgrave changed the base branch from master to dev October 18, 2023 01:55
@KevinMusgrave
Copy link
Copy Markdown
Owner

Thanks @GaetanLepage !

@KevinMusgrave KevinMusgrave merged commit a36ee78 into KevinMusgrave:dev Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants