Skip to content

Use OfType instead of Cast when iterating nested content config array #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinJump merged 2 commits into from
Mar 4, 2026
Merged

Use OfType instead of Cast when iterating nested content config array #904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecc9712
Initial plan
Copilot Mar 4, 2026
c6180ea
Use OfType instead of Cast for resilience to non-object array entries
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion uSync.Core/DataTypes/DataTypeSerializers/NestedContentMigratingConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public override IDictionary<string, object> GetConfigurationImport(IDictionary<s
if (configuration.TryGetValue("contentTypes", out var contentTypes) && contentTypes is JsonArray contentTypesArray)
{
var blocks = new List<BlockListConfiguration.BlockConfiguration>();
foreach (var contentType in contentTypesArray.Cast<JsonObject>())
foreach (var contentType in contentTypesArray.OfType<JsonObject>())
{
if (contentType["ncAlias"]?.ToString() is not string alias) continue;
var contentTypeItem = _contentTypeService.Get(alias);
Expand Down