Skip to content

normalize string media paths into JSON croppers for consistancy. #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinJump merged 1 commit into from
Oct 2, 2025
Merged

normalize string media paths into JSON croppers for consistancy. #812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions uSync.Core/Mapping/Mappers/ImagePathMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;

using System.Text.Json;
using System.Text.Json.Serialization;
using System.Text.RegularExpressions;

using Umbraco.Cms.Core;
using Umbraco.Cms.Core.Configuration.Models;
using Umbraco.Cms.Core.PropertyEditors.ValueConverters;
using Umbraco.Cms.Core.Services;
using Umbraco.Extensions;

Expand Down Expand Up @@ -70,10 +73,11 @@ public ImagePathMapper(
var stringValue = value?.ToString();
if (string.IsNullOrWhiteSpace(stringValue)) return stringValue;


if (stringValue.TryParseToJsonObject(out var json) is false || json is null)
return StripSitePath(stringValue);

{
var cropper = new ImageCropperValue() { Src = StripSitePath(stringValue) };
return cropper.SerializeJsonString();
}

if (json.TryGetPropertyValue("src", out var source) is true && source is not null)
{
Expand Down
Loading