add waiting state to the import upload button.#797
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a waiting state to the import upload button to provide visual feedback during file upload operations. The button will display a spinning state while the upload is in progress and show a success state when complete.
- Imports UUIButtonState type from Umbraco CMS backoffice
- Adds button state management to track upload progress
- Updates button template to bind the state property
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| usync-file-upload.element.ts | Adds button state management and visual feedback for upload operations |
| en-us.ts | Adds translation for import header text |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| value.forEach((file) => { | ||
| if (file.status === TemporaryFileStatus.SUCCESS) { | ||
| this.#uploadComplete(file.temporaryUnique); | ||
| this.buttonState = 'success'; |
There was a problem hiding this comment.
The button state is set to 'success' but never reset. This means subsequent uploads will start with a success state instead of the default state. Consider resetting the button state when starting a new upload or after a timeout.
alexsee
pushed a commit
to alexsee/umbraco-container
that referenced
this pull request
Sep 28, 2025
Updated [uSync](https://github.com/KevinJump/uSync) from 16.0.4 to 16.0.5. <details> <summary>Release notes</summary> _Sourced from [uSync's releases](https://github.com/KevinJump/uSync/releases)._ ## 16.0.5 This is a patch release for uSync v16 for Umbraco v16 - it contains some fixes to reported issues. ## What's Changed * add missing translations for summary (over 1000) titles in report das… by @KevinJump in KevinJump/uSync#796 * add waiting state to the import upload button. by @KevinJump in KevinJump/uSync#797 * Fix #800 Add blockItemConverters by @KevinJump in KevinJump/uSync#801 * V16/new trash handling by @KevinJump in KevinJump/uSync#802 * Fix - topological sort, - key not matching internally. by @KevinJump in KevinJump/uSync#803 **Full Changelog**: KevinJump/uSync@v16.0.4...v16.0.5 Commits viewable in [compare view](KevinJump/uSync@v16.0.4...v16.0.5). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the waiting state to the import button (so it spins while the upload happens).