Repository navigation
Umbraco 17.7 readiness: property move tests and culture casing - #1101
Merged
Merged
Conversation
…17.7 Umbraco 17.7 fixes MovePropertyType(alias, null) orphaning the property (umbraco/Umbraco-CMS#23493), so the test asserting that bug would fail. The re-home workaround stays for 17.3-17.6 and does nothing on 17.7. The move logic is now an internal helper, and the tests call it rather than a copy of it. Adds save-and-reload coverage for both directions. Refs #1067 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A language stored as 'da-dk' exported as 'da-dk' before Umbraco 17.7. From 17.7 (umbraco/Umbraco-CMS#23425) the name and published cultures come back as 'da-DK' while property values stay 'da-dk', so files mixed the two and changed on upgrade. Normalising in uSync gives the same output on every 17.x version. Tests also cover importing a culture in other casing, and that an unknown or invalid culture fails as a normal uSync import failure. Refs #1067 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
13 tasks done
4 of 5 tasks
This was referenced Sep 30, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works through #1067. Every test passes against both Umbraco 17.3.0 (our floor) and 17.7.0: 172 of 172.
Changes
Property moves (umbraco/Umbraco-CMS#23493). 17.7 fixes
MovePropertyType(alias, null)orphaning the property, which brokeMoveToNull_OrphansTheProperty(it asserted the bug). The re-home workaround stays because 17.3–17.6 still need it; on 17.7 it does nothing. The move logic moves into an internal helper so the tests call the real code. Integration tests now save and reload moves in both directions.null!stays, since the parameter only accepts null from 17.7.Culture casing (umbraco/Umbraco-CMS#23425). A language stored as
da-dkused to export asda-dkeverywhere. On 17.7 the name and published cultures becomeda-DKwhile property values stayda-dk. Culture codes are now written in standard casing on export (names, values, published, schedule), so output is the same on every 17.x. For the release notes: sites with odd-cased language codes will see a one-off change to their files on the next export.Checked, no change needed
UnattendedUpgraderrefreshes the published snapshot after package migrations on 17.3 and 17.7 alike.Refs #1067
🤖 Generated with Claude Code