Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump octokit/rest to v21 #1244

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Conversation

Kesin11
Copy link
Owner

@Kesin11 Kesin11 commented Jun 22, 2024

fix: #1113

Since v21.0.0, octokit/rest has been ESM.

@Kesin11
Copy link
Owner Author

Kesin11 commented Jun 22, 2024

It seems octokit/core that is peerDependency from @octokit/plugin-paginate-rest is conflicted.
@octokit/plugin-paginate-rest restricts @octokit/core to v5 by octokit/plugin-paginate-rest.js#597.

$ npm i
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @octokit/[email protected]
npm WARN Found: @octokit/[email protected]
npm WARN node_modules/@octokit/rest/node_modules/@octokit/core
npm WARN   peer @octokit/core@"5" from @octokit/[email protected]
npm WARN   node_modules/@octokit/rest/node_modules/@octokit/plugin-paginate-rest
npm WARN     @octokit/plugin-paginate-rest@"^11.0.0" from @octokit/[email protected]
npm WARN     node_modules/@octokit/rest
npm WARN   1 more (@octokit/plugin-rest-endpoint-methods)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @octokit/core@">=6" from @octokit/[email protected]
npm WARN node_modules/@octokit/rest/node_modules/@octokit/plugin-request-log
npm WARN   @octokit/plugin-request-log@"^5.1.0" from @octokit/[email protected]
npm WARN   node_modules/@octokit/rest
npm WARN 
npm WARN Conflicting peer dependency: @octokit/[email protected]
npm WARN node_modules/@octokit/core
npm WARN   peer @octokit/core@">=6" from @octokit/[email protected]
npm WARN   node_modules/@octokit/rest/node_modules/@octokit/plugin-request-log
npm WARN     @octokit/plugin-request-log@"^5.1.0" from @octokit/[email protected]
npm WARN     node_modules/@octokit/rest
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=20.14.0' },
npm WARN EBADENGINE   current: { node: 'v20.11.1', npm: '10.2.4' }
npm WARN EBADENGINE }

Copy link

Code Metrics Report

master (7e08d6e) octokit_v21 (83c2796) +/-
Coverage 40.9% 40.9% 0.0%
Test Execution Time 5s 5s 0s
Details
  |                     | master (7e08d6e) | octokit_v21 (83c2796) | +/-  |
  |---------------------|------------------|-----------------------|------|
  | Coverage            |            40.9% |                 40.9% | 0.0% |
  |   Files             |               43 |                    43 |    0 |
  |   Lines             |             5789 |                  5789 |    0 |
  |   Covered           |             2368 |                  2368 |    0 |
  | Test Execution Time |               5s |                    5s |   0s |

Reported by octocov

@Kesin11
Copy link
Owner Author

Kesin11 commented Jun 22, 2024

After reinstalling all octokit packages and re-creating package-lock.json, @octokit/[email protected] is picked and everything was resolved.

@Kesin11 Kesin11 added the dependencies Pull requests that update a dependency file label Jun 22, 2024
@Kesin11 Kesin11 merged commit 68b1463 into renovate/major-octokit-monorepo Jun 22, 2024
9 checks passed
@Kesin11 Kesin11 deleted the octokit_v21 branch June 22, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant